Skip to content

fix: fallback to the dependencies latest tag in Build and publish npm package #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppawlowski merged 1 commit into from
Feb 26, 2026
Merged

fix: fallback to the dependencies latest tag in Build and publish npm package #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/publish_node_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,14 @@ jobs:
if [ "$dependency_name" == "$dependency_version" ]; then
dependency_version="nightly"
fi
dependency_semver=$(npm view $dependency_name dist-tags --json | jq -r --arg version "$dependency_version" '.[$version]')
dependency_semver=$(npm view "$dependency_name" dist-tags --json | jq -r --arg version "$dependency_version" '.[$version]')
if [ -z "$dependency_semver" ] || [ "$dependency_semver" = "null" ]; then
if [ "$dependency_version" = "nightly" ]; then

@hardillb hardillb Feb 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If equal nightly fall back to latest?

This looks like it's missing a negation?

@ppawlowski ppawlowski Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic:

  1. If a dependency exact version is specified, use it. Fail the script if the explicitly specified version is not in a npm registry (something went wrong while publishing a dependency package)
  2. if dependency version is not set (just package name), set the version to nightly and try to resolve its actual semver version
  3. is semver version for the nightly tag is unresolvable (does not exist or npm registry error), fallback to the latest tag. But only if nighlty tag version resolution fails. We do not want to fail to the latest tag if a dependency was specified in some actual version number (see step 1)

@hardillb hardillb Feb 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh, missed dependency_version vs dependency_semver

echo "Could not resolve $dependency_name@nightly, falling back to latest"
dependency_version="latest"
dependency_semver=$(npm view "$dependency_name" dist-tags --json | jq -r --arg version "$dependency_version" '.[$version]')
fi
fi
if [ -z "$dependency_semver" ] || [ "$dependency_semver" = "null" ]; then
echo "::error title=Dependency resolution failed::Could not resolve $dependency_name@$dependency_version."
exit 1
Expand Down