Skip to content

Update tab-presence topics to include browser prefix and adjust condition checks - #8194

Merged
Steve-Mcl merged 1 commit into
mainfrom
fix/discrepancy-between-tab-presence-topics
Aug 14, 2026
Merged

Update tab-presence topics to include browser prefix and adjust condition checks#8194
Steve-Mcl merged 1 commit into
mainfrom
fix/discrepancy-between-tab-presence-topics

Conversation

@cstns

@cstns cstns commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

align the pub/sub topics between the frontend/backend on tab presence

Related Issue(s)

n/a

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns
cstns requested a review from Steve-Mcl August 14, 2026 15:49
@cstns cstns self-assigned this Aug 14, 2026
@cstns
cstns deployed to staging August 14, 2026 15:52 — with GitHub Actions Active
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.16%. Comparing base (4fe037c) to head (39bc354).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
forge/comms/commsClient.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8194   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files         442      442           
  Lines       23694    23694           
  Branches     6306     6306           
=======================================
  Hits        18047    18047           
  Misses       5647     5647           
Flag Coverage Δ
backend 76.16% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Steve-Mcl Steve-Mcl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-run on ui test needed

@Steve-Mcl
Steve-Mcl merged commit 3334229 into main Aug 14, 2026
36 of 38 checks passed
@Steve-Mcl
Steve-Mcl deleted the fix/discrepancy-between-tab-presence-topics branch August 14, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants