Froniter Oven and Medical Assembler Port#381
Froniter Oven and Medical Assembler Port#381Dunrab wants to merge 15 commits intoFloof-Station:masterfrom
Conversation
|
Giving this do not merge because this need a lot of testing and probably some additional fixes. |
|
RSI Diff Bot; head commit 0713d51 merging into eb29151 Resources/Textures/_NF/Objects/Specific/Medical/medipen.rsi
Resources/Textures/_NF/Structures/Machines/assembler.rsi
Resources/Textures/_NF/Structures/Machines/medical_assembler.rsi
Resources/Textures/_NF/Structures/Machines/oven.rsi
Resources/Textures/_NF/Structures/Machines/oven_syndie.rsi
|
|
This PR is of interest to my Cooking Rebaked project. If you need a hand, let me know. |
I will probably need help with this test failure, not sure what it means and or what is causing it |
Mnemotechnician
left a comment
There was a problem hiding this comment.
The fact that this changes the microwave system instead of doing literally anything else is awful
yeaaaah... i told you it did just that |
|
tested & video attached removing the do not merge tag |
| - RecipeThrowingCroissant | ||
|
|
||
| - type: entity | ||
| id: KitchenAssembler |
There was a problem hiding this comment.
What will be made with this? I cant find any recipes as part of your PR for the machine.
There was a problem hiding this comment.
This is not included in research, so this is admin only for now till we decide if we even want to keep it and or use it, maybe we can use this for machine for that one bounty thing that chefs could do for cash with bultertron?
There was a problem hiding this comment.
That's fine. We should keep it so they can assemble things. I am just unsure what that would be. Like, why have an assembler, when we have the lathes (both service and medical)?
There was a problem hiding this comment.
If im remembering right on Frontier, this was not used in that way, it was used for a few very specific food items, it has been a while though so that may have changed with time
| beginCookingSound: /Audio/_NF/Machines/egg-timer.ogg | ||
| foodDoneSound: /Audio/Machines/ding.ogg | ||
| loopingSound: /Audio/_NF/Effects/silence.ogg # need to change this sound | ||
| validRecipeTypes: Oven |
There was a problem hiding this comment.
Is it intended to be able to cook microwave recipes in the oven at the moment? Will there be a time when you can't, or does the component "microwave" mean it always will?
There was a problem hiding this comment.
So the range being able to cook microwave recipes is temporary, i felt it would to be silly to add it and it have no use at all, we can pull it research though if we want to remove that for now
What do you need to see for this to be okay to merge in? Or is it okay enough for now? |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Dunrab <72047814+Dunrab@users.noreply.github.com>
|
marking as dnm pending wizdens microwave refactor or potential microwave removal |



















































About the PR
Oh boy here we go, this PR ports Frontiers awesome Medical Assembler, special medical pens that can be made by chem in medical assembler and Frontiers Oven that can be used to cook specific sets of foods.
Original PRs from Froniter, credit too the people who worked to get all of this working.
Frontier PR that added the medical assembler & oven: Frontier #1935
Frontier PR that makes the guidebook for the assembler auto-generated: Frontier #2331
TODO:
Why / Balance
The medical assembler is a nice tool for chem to produce medical pens to give out to salvage, doctors, security or who ever. It is a great RP opportunity on frontier and I believe it will benefit RP here nicely.
The oven will be used in a future PR so specific recipes can be used in it.
The medical assembler and empty medipens are t3 biomedical research and the oven range is t2 civilian.
I increased the price per empty medipen but we can increase it further if desired.
Technical details
I ported both machines since they share code and figured why not knock two birds with one stone since both will provide small content updates for each department.
Media
Click to show
Medical.Assembler.mp4
Requirements
Licensing:
Breaking changes
Changelog
🆑