Shork

[Raikyr0]

About the PR

Ports the Shark Hard Toy, and finishes what I started by adding the other 2 sharks.
Added a funny contraband label for it.

I'll do some testing, then consider where one would get this normally.

Changelog
🆑

• add: Added Shork Hard Toy is back, with friends.

[SyaoranFox]

So, I do have a concern with this. I have seen this spawn on station from maints, and from shonk spawn locations (such as on some of our beaches). Would you consider the damage excessive for something you can find randomly?

[Raikyr0]

So, I do have a concern with this. I have seen this spawn on station from maints, and from shonk spawn locations (such as on some of our beaches). Would you consider the damage excessive for something you can find randomly?

So, they weren't/aren't in any of the spawning pools, I can only assume a mapper added them in as a joke.

Damage wise, they're a little lower then the forged swords. You can throw em for a quite bit more, but also, if you throw it, the other person can just pick it up.

[Mnemotechnician]

Also these need a suffix like [DO NOT MAP] because we used to have one of those hard-mapped.

[Mnemotechnician]

Nmaespace

[JFerrix]

There is also the case of using an abstract class as basis, for example, each one of the toys uses the MeleeWeapon component with nearly identical values in most places, same with the DamageOtherOnHit component. A recommendation would be to expand the BaseTwinkContraband object to contain these components so you dont need to re-implement these for every toy, reducing code duplication and makes adding new ones easier for later. Not exactly world changing but I dont see a reason not to. Also where would these even show up? Because for random maint loot these, especially the blue one seems a bit busted. The pink one is fine by me honestly but the blue and gray one seem a bit on the strong end because pierce and slash are kinda strong. Even if they are comparable to forged swords, those require quite a few gameplay loops to go through. And if its an uplink item then having three nearly identical ones in there seems a bit redundant

[Raikyr0]

There is also the case of using an abstract class as basis, for example, each one of the toys uses the MeleeWeapon component with nearly identical values in most places, same with the DamageOtherOnHit component. A recommendation would be to expand the BaseTwinkContraband object to contain these components so you dont need to re-implement these for every toy, reducing code duplication and makes adding new ones easier for later. Not exactly world changing but I dont see a reason not to. Also where would these even show up? Because for random maint loot these, especially the blue one seems a bit busted. The pink one is fine by me honestly but the blue and gray one seem a bit on the strong end because pierce and slash are kinda strong. Even if they are comparable to forged swords, those require quite a few gameplay loops to go through. And if its an uplink item then having three nearly identical ones in there seems a bit redundant

So, there's reasons why I didn't add it to the BaseTwinkContraband, simply because if i wanted to add objects with the funny tag, I'd need to change it again so it's not super specific for toy shark melees. More so future proofing.

As for balance, 16 was a fair middle ground I believe, it's a little less then the 18 damage forged sword, altho it could be lowered further.

As for location of where it'd spawn, the last one was in the uplink, and an emagged pridevend (no one ever found it), I'm considering various options, like simply being to make them like swords, or a hacked pridevend.

[Mnemotechnician]

emagged pridevend is a no, I've seen the pridevend getting emagged by a revenant and the plushie sold off to a passenger way too many times

[Raikyr0]

Uplink and a PJ party plus bag I guess