Skip to content

chore(package): fix module resolution to support >=node10#4

Merged
Floffah merged 1 commit intomainfrom
feature/module-resolution
Mar 4, 2026
Merged

chore(package): fix module resolution to support >=node10#4
Floffah merged 1 commit intomainfrom
feature/module-resolution

Conversation

@Floffah
Copy link
Copy Markdown
Owner

@Floffah Floffah commented Mar 4, 2026

What this changes

Used ATTR & publint to ensure that all packages and paths are resolvable on node10, node16, and in bundlers

How I tested this

Build command now runs ATTR and publint

Checklist

  • I have read CONTRIBUTING.md and this PR follows the guidelines
  • A human has reviewed the entire diff of this PR, every line of code
  • A human understands the changes and can explain why this approach is correct
  • This PR doesn't have AI-generated boilerplate or co-author lines
  • Tests pass
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have created a changeset (if appropriate)
  • This PR was authored and submitted by an AI agent without human review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

Worth a look

Unchecked items in the PR checklist

Each checkbox is an attestation — please fill them in honestly. If one doesn't apply to your change, note why in the description.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 4, 2026

🦋 Changeset detected

Latest commit: 58821e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Floffah Floffah marked this pull request as ready for review March 4, 2026 14:46
Copilot AI review requested due to automatic review settings March 4, 2026 14:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the monorepo packaging/build setup to validate published artifacts across different resolution environments (via ATTW + publint), and adjusts build outputs/exports to improve module/type resolvability.

Changes:

  • Add a lint:package Turbo task and wire it into the root build pipeline.
  • Update @sqts/core and @sqts/sql build/package metadata for dual ESM/CJS outputs (custom extensions, type: module, updated exports).
  • Add a changeset and update lockfile/dependency versions to support the new packaging checks.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
turbo.json Adds lint:package task to Turbo config.
package.json Runs turbo lint:package as part of build; adds ATTW CLI dependency and bumps tooling versions.
packages/core/tsdown.config.ts Adjusts build output extensions and Node protocol handling; updates externals.
packages/sql/tsdown.config.ts Adjusts build output extensions and externals.
packages/core/package.json Updates package to ESM-by-default metadata + conditional exports/types layout; adds lint:package script.
packages/sql/package.json Updates package to ESM-by-default metadata + conditional exports/types layout; adds lint:package script.
.changeset/tall-glasses-think.md Declares patch releases for @sqts/core and @sqts/sql.
bun.lock Lockfile updates for added/changed tooling deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Floffah Floffah merged commit c48ca79 into main Mar 4, 2026
7 checks passed
@Floffah Floffah deleted the feature/module-resolution branch March 4, 2026 14:56
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants