feat(service-providers): default to reachable nodes and add endorsed provider badge by beck-8 · Pull Request #269 · FilOzone/filecoin-cloud

beck-8 · 2026-03-19T08:52:54Z

📝 Description

Adds a default accessibility filter so only reachable providers are shown by default.
Marks approved providers with an 🏅 badge and adds a footnote explaining the badge.

ps:

Use the version field to determine whether it is reachable. This is the interface of curio. Unreachable means that the service is unavailable or the network is unreachable. The field level may cause the reviewer to raise a question, so I will clarify it here.
The filter count will display 1 by default, which is also my intention. Let incoming users know that reachable SP nodes are filtered by default.

📸 Screenshots

…ibility

vercel · 2026-03-19T08:52:58Z

@beck-8 is attempting to deploy a commit to the FilOz Team on Vercel.

A member of the Team first needs to authorize it.

beck-8 · 2026-03-19T08:54:11Z

@mirhamasala If you have time, please take a look at this, thank you

cc @jennijuju

Copilot

Pull request overview

Adds a default “reachable/accessible” filter to the Service Providers table and introduces an “Endorsed Provider” badge for approved providers to improve default usability and trust signaling within the service-providers UI.

Changes:

Default filter state now includes a “reachable” (software version present) constraint and a corresponding ReachableFilter UI.
Approved providers are marked with a 🏅 badge in the provider name cell and explained via a table footnote.
Table column filtering is wired to apply the new reachable filter on the softwareVersion column.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/components/ProviderOverview.tsx	Adds `isApproved` prop and renders 🏅 badge next to provider name when approved.
src/app/service-providers/utils/service-provider-filters.ts	Adds `reachableFilterFn` to filter by accessibility via `softwareVersion` presence.
src/app/service-providers/utils/map-filter-state-to-column-filters.ts	Maps `reachable` query state to a column filter on `softwareVersion`.
src/app/service-providers/hooks/use-filter-query-state.ts	Adds `reachable` to filter state with a default of `['true']`.
src/app/service-providers/data/column-definition.tsx	Passes `isApproved` to ProviderOverview and attaches `reachableFilterFn` to the version column.
src/app/service-providers/components/ServiceProvidersTable.tsx	Adds footnote explaining the 🏅 badge.
src/app/service-providers/components/ReachableFilter.tsx	New filter UI (Accessible/Unavailable) that toggles the `reachable` query state.
src/app/service-providers/components/MobileTableFilters.tsx	Includes ReachableFilter in the mobile filters panel.
src/app/service-providers/components/DesktopTableFilters.tsx	Includes ReachableFilter in the desktop filters popover.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/components/ProviderOverview.tsx

beck-8 · 2026-03-19T09:25:51Z

src/app/service-providers/hooks/use-filter-query-state.ts

+const DEFAULT_REACHABLE_FILTER = ['true']
+
 const filterParsers = {
  status: parseAsArrayOf(parseAsString).withDefault([]),
  location: parseAsArrayOf(parseAsString).withDefault([]),


This is intentional

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CharlyMartin

Left a few inline comments.

CharlyMartin · 2026-03-25T11:18:23Z

src/app/service-providers/data/column-definition.tsx

    },
    sortingFn: sortSoftwareVersion,
    sortUndefined: 'last',
+    filterFn: reachableFilterFn,


The reachable filter is attached to the softwareVersion column, which means this column now carries two concerns (displaying version + filtering reachability). If another filter is ever applied to this column, they'd conflict. Worth considering a dedicated virtual/computed column for reachability to keep things clean and make the relationship explicit.

CharlyMartin · 2026-03-25T11:18:26Z

src/app/service-providers/hooks/use-filter-query-state.ts

+  reachable: Array<string>
 }

+const DEFAULT_REACHABLE_FILTER = ['true']


Since the default is ['true'], activeFilterCount starts at 1 and hasActiveFilters is true on first load. Does clearFilterQueries (which sets to null) reset back to this default or to empty? If it resets to ['true'], there's no way for users to truly "show all" via the clear button.

CharlyMartin · 2026-03-25T11:18:28Z

src/app/service-providers/hooks/use-filter-query-state.ts

  provingPeriodMax: number | null
  ipni: Array<string>
  serviceTier: Array<ServiceTier>
+  reachable: Array<string>


This is typed as Array<string> but the only valid values are 'true' and 'false'. Could use a stricter type like Array<'true' | 'false'> to catch misuse at compile time — similar to how serviceTier uses a specific union.

CharlyMartin · 2026-03-25T11:18:30Z

src/app/service-providers/utils/service-provider-filters.ts

+  const reachableArray = filterValue as FilterState['reachable']
+  if (reachableArray.length === 0) return true
+
+  const isAccessible = Boolean(row.original.softwareVersion)


Using softwareVersion truthiness as a proxy for reachability is indirect. If a provider has an empty string version or any other falsy-but-valid value, it'd be incorrectly marked as unreachable. Might be worth a comment explaining this proxy, or better yet, a dedicated field if the API supports it.

Yes, pdp has a dedicated endpoint /pdp/ping, and I'm being lazy or changing as little as possible, so I did.

CharlyMartin · 2026-03-25T11:18:32Z

src/components/ProviderOverview.tsx

  description: string
  address: string
  serviceUrl: string
+  isApproved?: boolean


Since column-definition.tsx always passes row.isApproved, this could be required instead of optional with a default. Makes the data contract more explicit.

beck-8 · 2026-03-26T04:12:01Z

@CharlyMartin Please take a look again

beck-8 · 2026-03-26T15:16:40Z

Endorsed Provider (approved list)

~~here is the approved list, but I wrote Endorsed , I'm not sure if there is any controversy here.~~

beck-8 · 2026-03-26T15:37:34Z

beck-8 added 2 commits March 19, 2026 15:50

feat(service-providers): add default reachable filter for node access…

abd992e

…ibility

feat(service-providers): mark approved providers with endorsed badge

447868c

mirhamasala requested a review from Copilot March 19, 2026 09:00

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Potential fix for pull request finding

653dcc5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CharlyMartin self-requested a review March 23, 2026 11:43

CharlyMartin reviewed Mar 25, 2026

View reviewed changes

beck-8 added 2 commits March 25, 2026 21:43

fix(filters): tighten reachable typing and fix ProviderOverview usage

7c6b46f

refactor(provider-overview): require isApproved prop explicitly

ed92f89

feat(providers): split endorsed status from approved and update legend

8712123

chore(ci): align biome schema and format legend

cc831ad

CharlyMartin self-requested a review March 26, 2026 15:46

CharlyMartin approved these changes Mar 26, 2026

View reviewed changes

Conversation

beck-8 commented Mar 19, 2026

📝 Description

📸 Screenshots

Uh oh!

vercel bot commented Mar 19, 2026

Uh oh!

beck-8 commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

beck-8 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

CharlyMartin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CharlyMartin Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

CharlyMartin Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

CharlyMartin Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CharlyMartin Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beck-8 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

CharlyMartin Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beck-8 commented Mar 26, 2026

Uh oh!

beck-8 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

beck-8 commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CharlyMartin left a comment •

edited

Loading

CharlyMartin Mar 25, 2026 •

edited

Loading

CharlyMartin Mar 25, 2026 •

edited

Loading

CharlyMartin Mar 25, 2026 •

edited

Loading

beck-8 commented Mar 26, 2026 •

edited

Loading