refactor: rehome prometheus operational gauges by Chaitu-Tatipamula · Pull Request #401 · FilOzone/dealbot

Chaitu-Tatipamula · 2026-03-26T19:06:39Z

Summary

Moves the operational Prometheus gauges (wallet_balance, storage_providers_active, storage_providers_tested) out of MetricsSchedulerService to ensure they survive the upcoming deletion of the legacy metrics module.

What Changed

wallet_balance → now uses a scrape-time collect() callback in metrics-prometheus/wallet-balance.collector.ts with a 1-hour TTL cache to avoid hammering the chain RPC.
storage_providers_* → Now updated locally as a side-effect at the end of the existing providers.refresh pg-boss job in jobs.service.ts.
removed original gauge logic, constructor injections, and unneeded ConfigService from MetricsSchedulerService.

Why

part of the metrics removal epic (#275). MetricsSchedulerService is marked for deletion, but these 3 gauges report live telemetry to Grafana and must be preserved. The new locations follow the strategy agreed upon in the issue thread.

Testing

pnpm typecheck ✅
pnpm test (all 280 tests pass) ✅
pnpm check:ci (Biome) ✅
Local tests confirm cache TTL works and chain reads are skipped when DEALBOT_DISABLE_CHAIN=true.

Part of #275

…metheus move check-metrics.service.ts and check-metric-labels.ts to metrics-prometheus/ and update all imports across deal/, retrieval/, data-retention/, deal-addons/, and metrics-prometheus.module.ts.

Copilot

Pull request overview

Rehomes three operational Prometheus gauges (wallet_balance, storage_providers_active, storage_providers_tested) away from the legacy MetricsSchedulerService so they remain available as the legacy metrics module is removed (part of #275).

Changes:

Adds a scrape-time wallet_balance collector with a 1-hour TTL cache.
Updates storage_providers_* gauges at the end of the existing providers.refresh pg-boss job.
Moves check-metric label/metrics helpers to metrics-prometheus/ and updates imports across services/tests; removes the old gauge update logic from MetricsSchedulerService.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
apps/backend/src/retrieval/retrieval.service.ts	Switches check metrics imports to `metrics-prometheus/`.
apps/backend/src/retrieval/retrieval.service.spec.ts	Updates test imports to `metrics-prometheus/`.
apps/backend/src/providers/providers.service.ts	New providers API service (DB queries + Curio version fetch).
apps/backend/src/providers/providers.module.ts	Registers Providers controller/service + TypeORM repo.
apps/backend/src/providers/providers.controller.ts	New `/api/v1/providers` endpoints (list + Curio version proxy).
apps/backend/src/providers/providers.controller.spec.ts	Adds regression coverage for BigInt serialization in provider list.
apps/backend/src/metrics/services/metrics-scheduler.service.ts	Removes legacy operational gauge update logic/injections.
apps/backend/src/metrics/controllers/providers.controller.ts	Removes list/Curio-version endpoints from legacy metrics controller.
apps/backend/src/metrics-prometheus/wallet-balance.collector.ts	New scrape-time collector implementing TTL caching.
apps/backend/src/metrics-prometheus/wallet-balance.collector.spec.ts	Unit tests for TTL behavior and chain-disable behavior.
apps/backend/src/metrics-prometheus/metrics-prometheus.module.ts	Registers `WalletBalanceCollector` and updates check-metrics imports.
apps/backend/src/metrics-prometheus/check-metrics.service.ts	Fixes relative imports after rehome.
apps/backend/src/metrics-prometheus/check-metric-labels.ts	New home for check label builder + failure classification.
apps/backend/src/jobs/jobs.service.ts	Injects provider gauges and updates them after `providers.refresh`.
apps/backend/src/jobs/jobs.service.spec.ts	Adds coverage for provider gauge update logic and approval filtering.
apps/backend/src/deal/deal.service.ts	Switches check metrics imports to `metrics-prometheus/`.
apps/backend/src/deal/deal.service.spec.ts	Updates test imports to `metrics-prometheus/`.
apps/backend/src/deal-addons/strategies/ipni.strategy.ts	Switches check metrics imports to `metrics-prometheus/`.
apps/backend/src/deal-addons/strategies/ipni.strategy.spec.ts	Updates test imports to `metrics-prometheus/`.
apps/backend/src/data-retention/data-retention.service.ts	Switches check label imports to `metrics-prometheus/`.
apps/backend/src/data-retention/data-retention.service.spec.ts	Updates test imports to `metrics-prometheus/`.
apps/backend/src/app.module.ts	Adds `ProvidersModule` to the backend app module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/backend/src/providers/providers.service.ts

apps/backend/src/metrics-prometheus/wallet-balance.collector.ts

apps/backend/src/jobs/jobs.service.ts

apps/backend/src/providers/providers.controller.ts

… version endpoints

…hecks

silent-cipher

MetricsPrometheusModule does not import WalletSdkModule, even though WalletSdkService required by WalletBalanceCollector. This leads to a startup failure.

We should add the missing module import to resolve this.

apps/backend/src/metrics-prometheus/wallet-balance.collector.ts

- add concurrency lock (refreshPromise) to WalletBalanceCollector to prevent concurrent RPC calls on TTL expiry - add 1-minute error cooldown (errorCooldownMs) to prevent hammering the RPC during outages - fix early return in JobsService so DB-backed provider gauges update even when chain integration is disabled - update unit tests to cover new collector behaviors"

…oldown - add missing WalletSdkModule import to MetricsPrometheusModule - extract prometheus wallet balance TTL and error cooldown times into app.config.ts - update WalletBalanceCollector to read cache timers dynamically from ConfigService"

silent-cipher

Can we update docs/environment-variables.md with the new variables?
Also, should we accept seconds instead of milliseconds for these values?

…config & update docs

Chaitu-Tatipamula added 3 commits March 26, 2026 01:14

refactor: move check-metric helpers from metrics/utils to metrics-pro…

e7a7f7c

…metheus move check-metrics.service.ts and check-metric-labels.ts to metrics-prometheus/ and update all imports across deal/, retrieval/, data-retention/, deal-addons/, and metrics-prometheus.module.ts.

refactor: extract providers API into standalone module

bf38cde

style: fix biome import ordering and trailing blank line

2198886

FilOzzy added this to FOC Mar 26, 2026

github-project-automation bot moved this to 📌 Triage in FOC Mar 26, 2026

silent-cipher requested a review from Copilot March 27, 2026 05:24

Copilot started reviewing on behalf of silent-cipher March 27, 2026 05:24 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Chaitu-Tatipamula added 2 commits March 27, 2026 14:14

refactor: remove legacy metrics providers service and redundant curio…

103621e

… version endpoints

fix(providers): address pagination falsiness bug with explicit null c…

cdda74f

…hecks

Chaitu-Tatipamula force-pushed the rehome-operational-gauges branch 3 times, most recently from 2b2f59d to 4c50515 Compare March 27, 2026 11:06

BigLep assigned Chaitu-Tatipamula Mar 27, 2026

BigLep requested a review from silent-cipher March 27, 2026 15:27

BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Mar 27, 2026

silent-cipher requested changes Mar 30, 2026

View reviewed changes

apps/backend/src/metrics-prometheus/wallet-balance.collector.ts Outdated Show resolved Hide resolved

github-project-automation bot moved this from 🔎 Awaiting review to ⌨️ In Progress in FOC Mar 30, 2026

Chaitu-Tatipamula requested a review from silent-cipher March 30, 2026 18:35

Chaitu-Tatipamula added 4 commits March 31, 2026 01:37

fix(providers): add ProviderListResponseDto for swagger docs

68e5110

refactor: rehome prometheus gauges from metrics scheduler

361c589

Chaitu-Tatipamula force-pushed the rehome-operational-gauges branch from da29217 to c98b701 Compare March 30, 2026 20:08

silent-cipher reviewed Mar 31, 2026

View reviewed changes

feat(prometheus): use seconds instead of ms for wallet balance cache …

7537f3c

…config & update docs

Chaitu-Tatipamula requested a review from silent-cipher March 31, 2026 17:29

silent-cipher approved these changes Apr 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: rehome prometheus operational gauges#401

refactor: rehome prometheus operational gauges#401
Chaitu-Tatipamula wants to merge 10 commits intoFilOzone:mainfrom
Chaitu-Tatipamula:rehome-operational-gauges

Chaitu-Tatipamula commented Mar 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silent-cipher left a comment

Uh oh!

Uh oh!

silent-cipher left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Chaitu-Tatipamula commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Why

Testing

Part of #275

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silent-cipher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

silent-cipher left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Chaitu-Tatipamula commented Mar 26, 2026 •

edited

Loading