Define PI and other constant and constexpr instead of macro #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it might interfer with another symbol defined in another library. This was the case for the symbol PI and was causing the build to fail with the following error: `error: expected unqualified-id before numeric constant` In order to ensure that there is no confusion possible, also prefix all the PI constants by STEERING.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had issues building the steering_functions repositroy in my project. In order to be able to build it I had to apply the modifications that I add in this pull request. I think that it improves the general quality and reliability of this code so I am opening a pull request to share it with you.
This mainly change the definition of PI and all PI related functions in the steering_functions repository to ensure that there is no confusion possible with a macro / symbol from another library and use a
constexprinstead of aDEFINEto ensure that the variable is typed.I am open to modification if you have another idea of performing this update.