[idea] Less icon refresh#1740
Open
yfdyh000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The extension is easy to use, but it is also huge and I feel a performance pressure. When I analyze performance (profiler & debugging) for this extension, I see that the icon refresh seems to be a big time, it may happen multiple times in a short time, and it seems to cache less.
The code change attempts to limit more than one change in one second. A better approach might be to reduce the trigger or use some queue like LIFO (but discard older).
Compatibility
Is this PR compatible with old versions? Can users simply upgrade the extension?
Should be yes.
Please describe any possible breaking changes (or surprising UX differences).
This may cause the icon refresh stutter, although I didn't see it, and the switch tabs should refresh it.
Screenshots (if applicable)
N/A.