Skip to content

Fix #1622: @JsonIgnoreProperties not applied due to deserializer cach… #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacksonJang wants to merge 1 commit into
base: 3.x
Choose a base branch
from
+443 −220
Open

Fix #1622: @JsonIgnoreProperties not applied due to deserializer cach… #5502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/tools/jackson/databind/deser/bean/BeanDeserializerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,14 @@ public ValueDeserializer<?> createContextual(DeserializationContext ctxt,
if (oir != null && oir != _objectIdReader) {
contextual = contextual.withObjectIdReader(oir);
}

// [databind#1622]:
if (_propertyBasedCreator == null && _valueInstantiator.canCreateFromObjectWith()) {
SettableBeanProperty[] creatorProps = _valueInstantiator.getFromObjectArguments(ctxt.getConfig());
_propertyBasedCreator = PropertyBasedCreator.construct(
ctxt, _valueInstantiator, creatorProps, _beanProperties);
}

// And possibly add more properties to ignore
if (accessor != null) {
contextual = _handleByNameInclusion(ctxt, intr, contextual, accessor);
Expand Down
4 changes: 1 addition & 3 deletions .../CreatorWithIgnoreProperties3355Test.java → .../CreatorWithIgnoreProperties3355Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tools.jackson.databind.tofix;
package tools.jackson.databind.deser;

import org.junit.jupiter.api.Test;

Expand All @@ -8,7 +8,6 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import tools.jackson.databind.ObjectMapper;
import tools.jackson.databind.testutil.DatabindTestUtil;
import tools.jackson.databind.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.assertNotNull;

Expand Down Expand Up @@ -53,7 +52,6 @@ public Common3355 getCommon() {

private final ObjectMapper MAPPER = newJsonMapper();

@JacksonTestFailureExpected
@Test
public void testDeserFailing() throws Exception
{
Expand Down
Loading