Merged
Conversation
a1batross
reviewed
Feb 2, 2026
IntriguingTiles
force-pushed
the
big-endian-upstreaming
branch
from
095888b to
b3bf0c0
Compare
a1batross
approved these changes
Feb 19, 2026
Member
a1batross
left a comment
a1batross
left a comment
There was a problem hiding this comment.
Looks good to me.
@nekonomicon what do you think?
IntriguingTiles
force-pushed
the
big-endian-upstreaming
branch
from
b3bf0c0 to
39897b5
Compare
Contributor
Author
|
Realized I forgot to add the s390x stuff to cmake and I didn't set |
Member
|
Yeah, there is some safeguards, though not all compilers set If it's gonna build, I will merge it. |
Contributor
Author
|
It builds and works on at least s390x and 32-bit powerpc. |
Member
|
Yeah, I meant the CI, sorry. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured I'd start with something relatively small. This should be everything that needs to be byteswapped in hlsdk.
I've also added definitions for the s390x architecture which is the only big endian architecture that has official support from debian and some other big distros, which might be useful for CI.