make: opam distribution on macs#682
Merged
Merged
Conversation
Contributor
Author
|
related pulse change: FStarLang/pulse#582 |
Collaborator
|
Thanks. Did you try this on OSX? We don't have OSX on our CI right now |
amosr-msft
marked this pull request as draft
March 3, 2026 17:19
Contributor
Author
|
sorry - I jumped the gun! ... will let you know once it's fully tested |
Relax the opam build rules to always have a fallback option. Previously the constraints were too tight if on mac with OPAMMAKECMD set. Disable the gtime check if NOSHORTLOG is set. Previously was failing on mac if gtime is not installed, but this is actually unused in opam with logging disabled.
amosr-msft
force-pushed
the
amos/20260227-mac-again
branch
from
March 3, 2026 17:24
b68038f to
e028943
Compare
Contributor
Author
|
I was able to get this building on our mac build servers, but then ran into unrelated problems with our infrastructure, so have had to shelve it for now. this change seems to be working but I'll park this for now until I can get our infrastructure problems sorted |
Collaborator
|
It's not a super deep change and I work on Mac, so if you want to go ahead and merge this, do not hesitate |
amosr-msft
marked this pull request as ready for review
March 19, 2026 22:15
Contributor
Author
|
hey, thanks - sorry to drop the ball on testing this. yes, if you're keen it'd be great to get this merged |
protz
enabled auto-merge
March 19, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the opam build rules to always have a fallback option. Previously the constraints were too tight if on mac with OPAMMAKECMD set.
Disable the gtime check if NOSHORTLOG is set. Previously was failing on mac if gtime is not installed, but this is actually unused in opam with logging disabled.