bgpd: Fix bgp peer clearing logic #19644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:rerun |
ton31337
reviewed
Sep 30, 2025
mjstapp
force-pushed
the
fix_bgp_clearing
branch
from
95a1f6f to
c265eab
Compare
|
@Mergifyio rebase |
added 3 commits
October 2, 2025 12:03
Not needed, just remove it. Signed-off-by: Mark Stapp <[email protected]>
Remove a duplicated prototype - only need the one... Signed-off-by: Mark Stapp <[email protected]>
Ensure the clearing info object iteration correctly accounts for the "outer"/RD table and "inner" table nature of the VPN SAFIs. Improve some debugs, especially in the paths where the bgp dest object is an RD - the generic dest output format handler doesn't understand RDs. Signed-off-by: Mark Stapp <[email protected]>
✅ Branch has been successfully rebased |
ton31337
force-pushed
the
fix_bgp_clearing
branch
from
c265eab to
6693fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the clearing info object iteration correctly accounts for the "outer"/RD table and "inner" table nature of the VPN
SAFIs. Depending on the number of prefixes and number of RDs, the existing iteration logic could move past an RD value before completely removing all associated prefixes.
Also improve some debugs, especially in the paths where the bgp dest object is an RD - the generic bgp dest output format handler doesn't understand RDs.
Fixes: #19605