Option to disable closed loop idle when coasting in gear#496
Open
alrijleh wants to merge 10 commits intoFOME-Tech:masterfrom
Open
Option to disable closed loop idle when coasting in gear#496alrijleh wants to merge 10 commits intoFOME-Tech:masterfrom
alrijleh wants to merge 10 commits intoFOME-Tech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use clutchUp to recognize when the car is coasting in gear and return the phase as "coasting" instead of "idle". This prevents the closed loop integral term from dragging the rpm down once the clutch is engaged. The advantage of this over VSS, is now closed loop idle will still function when in neutral while the car is in motion.