fix(chell): quiet query polling, fast zero-match completion, spinner ghosting#38
Merged
Conversation
…ghosting The query poll probed the result decode every two seconds and each probe pushed 'has no result payload' onto the error stack — a zero-match query printed ~26 identical error lines and then timed out after 60s. The poll now pops the transient error it just caused, and once the PACS reports the query succeeded with no stored payload (plus two grace polls for result-write lag) it completes immediately through the existing 'no studies found' path: one line, ~7s, exit 0. The spinner frame now erases to end-of-line before writing, so a shorter status no longer shows the tail of a longer previous message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two field reports from interactive use, both reproduced and fixed:
1. Zero-match query = 26 error lines + 60s timeout.
pacsQuery_createAndWaitprobespacsQuery_resultDecodeevery 2s; each probe pushesPACS query N has no result payloadonto the error stack, and a query matching nothing rode the full 60s timeout. Now: each failed probe pops the transient error it just pushed, and once the PACS reportssucceededwith no stored payload (two grace polls cover result-write lag) the wait completes immediately through the existing "no studies found" path.Before / after, live against the instance with a no-match accession:
2. Spinner ghosting (
⣯ Query 2772 — succeeded (12.7s)ber:2324123... (0.7s)): the frame renderer wrote over the previous line with\rbut no erase, so shorter messages left the tail of longer ones. The frame now clears to end-of-line first.Tests: two new fake-timer cases (transient error popped per probe; succeeded-without-payload completes early, no timeout). chell suite 610 green; test query cleaned from the instance.