Feature/allow delete cb acbr #117
Conversation
| } | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Please dont change this file, its the original version as published by TMForum. The changes should go into the extension apis: https://github.com/FIWARE/tmforum-api/tree/main/customer-bill-management/api
| .map(tmForumMapper::map) | ||
| .map(HttpResponse::ok); | ||
| } | ||
|
|
There was a problem hiding this comment.
The changes need to be added to the extension controllers
|
Hi @wistefan I applied the requested changes, however it seems all tests are failing, I believe the problem should not be the code itself since it is affecting API's functionalities I have not modified. 
|
|
@droslbl Do they run on your local machine? It seem that currently some major internet outages happen, that also affect accessibility of docker-images. We need to rerun the tests after thats solved. |
|
Hi @wistefan Yes, they do run correctly, when the tests can rerun if something happens we will check it. |
|
Hi @wistefan , it seems everything is going back to normal, tests have passed, but label is required to proceed, tell us if you need anything else |
wistefan
added
the
patch
wistefan
left a comment
wistefan
left a comment
There was a problem hiding this comment.
just some minor cleanups
.../java/org/fiware/tmforum/customerbillmanagement/ExtendedAppliedCustomerBillingRateApiIT.java
Outdated
Show resolved
Hide resolved
.../java/org/fiware/tmforum/customerbillmanagement/ExtendedAppliedCustomerBillingRateApiIT.java
Outdated
Show resolved
Hide resolved
|
Hi @wistefan the cleanups have solved |
|
Hi @wistefan quick question, if i were to implement lastUpdate attribute in more entities shall it be done as part of extension api? |
If its an extension to the normal data model, it should come through a json schema @schemaLocation |
Hi @wistefan , is this response related to the lastUpdate attribute or is another requirement for the PR? |
2 participants
Greetings @wistefan
We were assigned the following ticket which in summary requests the addition of the delete REST request on CustomerBill and AppliedCustomerBillingRate
This is our first attempt adding requests to the API itself so we expect that something may not be alligned with the repository's conventions, so if you find something out of place or missing, please feel free to ask us and we will push the changes needed.
Thank you in advance