Refactor: replace config overlays with CLI flags, align defaults.conf#447
Merged
Refactor: replace config overlays with CLI flags, align defaults.conf#447
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Merged
11 tasks
…ate Scala Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
TODO: Revert to ref: main after system-integration PR #35 merges Co-Authored-By: Claude <noreply@anthropic.com>
…, and docs Co-Authored-By: Claude <noreply@anthropic.com>
- Add shard-monitoring.yml with cAdvisor + Prometheus + Grafana as a separate overlay compose file (monitoring was previously embedded in shard.yml). - Switch Prometheus from static_configs to dns_sd_configs for node discovery. Only running nodes get scraped — no false DOWN targets for standalone mode. - Add rule_files and cadvisor scrape job to prometheus.yml. - Move block-transfer.json into Grafana provisioning directory so it is auto-discovered alongside f1r3node.json. - Sync f1r3node.json dashboard with system-integration (24KB version with cAdvisor memory/CPU panels). - Update README and docker/README with monitoring section, fix duplicate monitoring heading, fix compose files table. Co-Authored-By: Claude <noreply@anthropic.com>
6 tasks
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Stop commands now include shard-monitoring.yml down before shard down, so monitoring containers (prometheus, grafana, cadvisor) are cleaned up. Co-Authored-By: Claude <noreply@anthropic.com>
…tion - Remove monitoring teardown from shard commands block and Quick Start Stop (monitoring not introduced yet at those points) - Add stop command to Monitoring section (self-contained start + stop) Co-Authored-By: Claude <noreply@anthropic.com>
PR #35 merged — no longer need to clone the feature branch. Co-Authored-By: Claude <noreply@anthropic.com>
Script runs the hybrid Scala+Rust node via JAR. The pure Rust node uses `just run-standalone` instead. Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
Merging. All review items will be addressed in follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default.conf,standalone-dev.conf). Per-role behavior controlled via CLI flags (--ceremony-master-mode,--heartbeat-disabled,--genesis-validator).${VAR:-default}fallbacks, unifiedf1r3flynetwork name (name: f1r3fly), F1R3_* runtime tuning env vars in x-rnode anchor.shard-monitoring.ymlas separate overlay (cAdvisor + Prometheus + Grafana). Prometheus uses DNS-based service discovery — no false DOWN targets for standalone mode. Recording rules loaded viarule_files.block-transfer.jsonmoved to provisioning directory.f1r3node.jsonsynced with system-integration (24KB with cAdvisor panels).synchrony-constraint-thresholdchanged to0across docker configs, defaults.conf, and documentation.ref: main(PR Add observers node deployment and fix bods.txt/wallets.txt in Helm #35 merged).Related PRs
Test plan
docker compose -f docker/shard.yml up -dstarts shard with all nodes reaching Runningdocker compose -f docker/shard-monitoring.yml up -dstarts monitoring stackdocker compose -f docker/standalone.yml up -d+ monitoring: 1 UP, 0 DOWNCo-Authored-By: Claude noreply@anthropic.com
Follow-up PRs
environment:sections with${VAR:-default}fallbacks is fragile. Follow-up to evaluate whether.envshould be the single source, or document the split clearly.