Skip to content

Conversation

gqcorneby
Copy link

@gqcorneby gqcorneby commented Jul 7, 2025

📌 References

📝 Implementation

  • always show companion year in Indicator selection and Summary

📹 Screenshots/Screen capture

Updated summary page:
image

2025-07-16.16-12-26.mp4

🔥 Notes to the tester

@gqcorneby gqcorneby requested a review from MiquelAdell July 7, 2025 05:22
@gqcorneby gqcorneby changed the title use current date as default scope Yearly companion updates Jul 7, 2025
@gqcorneby gqcorneby marked this pull request as ready for review July 10, 2025 13:18
@MiquelAdell
Copy link
Contributor

Hi @gqcorneby I have the following warnings when running yarn start:

[TypeScript] Found 0 errors. Watching for file changes.
 WARNING(ESLint)  'typeSectionText' is assigned a value but never used. Allowed unused vars must match /^_/u. (@typescript-eslint/no-unused-vars)
 FILE  /Users/miqueladell/code/dataset-configuration/src/webapp/components/dataset-wizard/SummaryDataSet.tsx:97:15

     95 |         const companionIndicatorTypes = indicator.keys();
     96 |
  >  97 |         const typeSectionText = React.useCallback(
        |               ^^^^^^^^^^^^^^^
     98 |             (type: string) => {
     99 |                 return (
    100 |                     <strong>

 WARNING(ESLint)  React Hook React.useCallback has an unnecessary dependency: 'requiredScope'. Either exclude it or remove the dependency array. (react-hooks/exhaustive-deps)
 FILE  /Users/miqueladell/code/dataset-configuration/src/webapp/components/dataset-wizard/SummaryDataSet.tsx:106:13

    104 |                 );
    105 |             },
  > 106 |             [requiredScope]
        |             ^^^^^^^^^^^^^^^
    107 |         );
    108 |
    109 |         return (

 WARNING(ESLint)  'type' is defined but never used. Allowed unused args must match /^_/u. (@typescript-eslint/no-unused-vars)
 FILE  /Users/miqueladell/code/dataset-configuration/src/webapp/components/dataset-wizard/SummaryDataSet.tsx:222:5

    220 |     isValid: boolean,
    221 |     message: Maybe<string>,
  > 222 |     type: "outcomes" | "outputs"
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    223 | ) {
    224 |     const allRulesSatisfied = i18n.t("All rules are satisfied");
    225 |     return isValid ? allRulesSatisfied : `${i18n.t("Rules not satisfied")}: ${message}`;

[ESLint] Found 0 error and 3 warnings

Could you check those? Thanks!

@gqcorneby
Copy link
Author

@MiquelAdell sorry about that! Just some unused references. I cleaned them up. Thanks!

@MiquelAdell MiquelAdell requested a review from eperedo July 16, 2025 06:16
Copy link
Contributor

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working

Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @gqcorneby

@MiquelAdell MiquelAdell merged commit 0ff4ba6 into development-project-configurator Jul 28, 2025
1 check passed
@MiquelAdell MiquelAdell deleted the fix/companion-always-show-years branch July 28, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants