Fix cursor position problems on mWeb #700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skalakid
changed the title
Skalakid
changed the title
jmusial
reviewed
Jun 18, 2025
| function mergeLinesWithMultilineTags(lines: Paragraph[], ranges: MarkdownRange[]) { | ||
| /** | ||
| * For singleline markdown types, the function splits markdown ranges that spread beyond the line length into separate lines. | ||
| * For multiline markdown types (like `pre`), it merges them and corresponsing text into one line. |
There was a problem hiding this comment.
Suggested change
| * For multiline markdown types (like `pre`), it merges them and corresponsing text into one line. | |
| * For multiline markdown types (like `pre`), it merges them and corresponding text into one line. |
| * For singleline markdown types, the function splits markdown ranges that spread beyond the line length into separate lines. | ||
| * For multiline markdown types (like `pre`), it merges them and corresponsing text into one line. | ||
| */ | ||
| function normalizeLines(lines: Paragraph[], ranges: MarkdownRange[]) { |
There was a problem hiding this comment.
this function has grown quite a bit :(
Maybe it can be refactored, so each case is a named function?
| * For singleline markdown types, the function splits markdown ranges that spread beyond the line length into separate lines. | ||
| * For multiline markdown types (like `pre`), it merges them and corresponsing text into one line. | ||
| */ | ||
| function normalizeLines(lines: Paragraph[], ranges: MarkdownRange[]) { |
There was a problem hiding this comment.
Would love some tests for this as well :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes issues with invalid cursor position on Android mWeb in cases when multiline markdown syntax is being removed. The problem lay in the current Live Markdown Input structure, where after splitting text into lines, we were merging all lines that contained ranges that go beyond the line length into one line. Now, if the markdown type isn't marked as a multiline type (the one that can have
<br>tags in it), we are corresponding ranges into separate lines.chrome.mWeb.mov
Related Issues
Expensify/App#57024
Manual Tests
Linked PRs