Toggle selection on deleted transaction row press in Search

[MelvinBot]

Explanation of Change

In Search, a deleted (trashed) transaction has no openable report — its only meaningful row interaction is toggling its selection checkbox. However, a press on the row body was routed to the navigation handler instead of the selection toggle:

• In the expanded grouped view (TransactionGroupListExpanded), handleOnPress only toggled selection when isMobileSelectionModeEnabled was true; otherwise it called openReportInRHP, which dead-ends for a trashed transaction.
• In the flat views (TransactionListItemWide / TransactionListItemNarrow), the deleted-row guard only short-circuited when canSelectMultiple was false. On desktop web (canSelectMultiple is true) the press fell through to onSelectRow, which can only navigate — and there is no report to open for a trashed expense, so the tap appeared to do nothing.

This change routes a row press on a deleted/pending-delete transaction to the existing selection handler (onSelectionButtonPress / onCheckboxPress, both wired to toggleTransaction) when multi-select is available, so tapping the row behaves the same as tapping its checkbox. Non-deleted rows still open via navigation, and a deleted row with multi-select off remains inert.

Fixed Issues

$ #93561
PROPOSAL: #93561 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changed worked.

1. Have an account with some deleted expenses.
2. Navigate to Spend > Expenses.
3. Open the Filter menu and set "Status" to "Deleted".
4. Enter the query group-by:from status:deleted in the search input.
5. Display dropdown > Edit columns > Select Action > Save.
6. Expand a table row.
7. Select a deleted expense via the checkbox.
8. Tap on the row (not the checkbox) of another deleted expense.
9. Verify the second row's checkbox toggles (selects/deselects), matching the behavior of tapping its checkbox directly.
10. Verify a non-deleted expense row still opens as before.

• Verify that no errors appear in the JS console

Offline tests

Selection is in-memory state only with no API dependency, so the row-press toggle works the same offline.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

1. Have an account with some deleted expenses.
2. Navigate to Spend > Expenses.
3. Open the Filter menu and set "Status" to "Deleted".
4. Enter the query group-by:from status:deleted in the search input.
5. Display dropdown > Edit columns > Select Action > Save.
6. Expand a table row.
7. Select a deleted expense via the checkbox.
8. Tap on the row of another deleted expense.
9. Verify the second row's checkbox toggles.
10. Verify a non-deleted expense row still opens as before.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

The failing check is unrelated to this PR — no fix pushed.

Failing check: test (job 6) → tests/ui/NewChatPageTest.tsx › "should keep a selected non-existing user visible in the top section after the search is cleared", with Unable to find an element with text: nonexistinguser@example.com.

Why it's unrelated: This PR only touches three Search transaction-list components — TransactionGroupListExpanded.tsx, TransactionListItemNarrow.tsx, and TransactionListItemWide.tsx. The failing test exercises the NewChatPage user-selection flow, which shares no code with the changed files (verified — none of the three components are imported by NewChatPage or its test). The Unable to find element ... after the search is cleared symptom is a render/timing assertion, the classic signature of a flaky async test.

Supporting evidence

• All other 7 test jobs passed; only job 6 failed.
• typecheck passed locally on this branch (exit 0, no errors in the changed files).
• ESLint, Prettier, unused-styles, React Compiler, knip all passed.
• grep for the three changed component names against NewChatPage* sources and the test file returned nothing → no shared dependency.

The other red check, PR Author Checklist / checklist, is a human-completed checklist — not something I can or should auto-fix.

Recommendation: Re-run job 6 (test (job 6)) to clear the flake. If it fails again deterministically on re-run, ping me and I'll dig deeper.

[MelvinBot]

Merged latest main to re-trigger the checks. No code fix was pushed — the only real failure is unrelated to this PR.

What I did: The branch was 5 commits behind main, so I merged main in (clean merge — only unrelated src/languages/* updates came along, none of this PR's files). The push kicks off a fresh CI run, which gives the flaky check a clean re-run.

The failing check (test (job 6)) is unrelated and flaky — same conclusion as my previous comment. It's tests/ui/NewChatPageTest.tsx › "should keep a selected non-existing user visible in the top section after the search is cleared", a NewChatPage user-selection test that shares no code with the three Search transaction-list components this PR touches. I confirmed there's no shared dependency, and typecheck + all other 7 test jobs passed.

The other red check, PR Author Checklist, is a human-completed checklist and not something I fix.

If test (job 6) fails again on this fresh run, ping me — that would mean it's deterministic rather than flaky and warrants a deeper look.

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...archList/ListItem/TransactionGroupListExpanded.tsx	64.51% <0.00%> (ø)
.../TransactionListItem/TransactionListItemNarrow.tsx	0.00% <0.00%> (ø)
...em/TransactionListItem/TransactionListItemWide.tsx	0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes