init #64793

DylanDylann · 2025-06-24T10:55:37Z

Explanation of Change

Fixed Issues

$ #64206
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-06-24T11:16:29Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-06-24T11:17:09Z

@ikevin127 Please ignore this PR now, I have made it ready to test easily

DylanDylann · 2025-06-26T09:03:29Z

src/components/Search/SearchRouter/SearchRouter.tsx

@@ -7,6 +7,8 @@ import {useOnyx} from 'react-native-onyx';
 import type {ValueOf} from 'type-fest';
 import HeaderWithBackButton from '@components/HeaderWithBackButton';
 import * as Expensicons from '@components/Icon/Expensicons';
+import {useOptionsList} from '@components/OptionListContextProvider';


This is some sample change to trigger workflow

DylanDylann · 2025-06-26T09:03:50Z

src/components/OptionListContextProvider.tsx


    useEffect(() => {
-        if (!shouldInitialize || areOptionsInitialized || isLoadingApp) {
+        if (!shouldInitialize || areOptionsInitialized) {


only to trigger workflow, please ignore

DylanDylann · 2025-06-26T09:08:36Z

@ikevin127 Could you join me from the implementation phase to process it faster?

We need to run test coverage on both the main branch and the current branch. But currently, the command to get the test coverage takes long time to complete on the workflow. You can see it in detail in PR Coverage Report -> Run Test Coverage

ikevin127 · 2025-06-26T09:36:39Z

@DylanDylann Sure, how can I help exactly - what's the TODO ?

DylanDylann · 2025-06-26T10:05:06Z

@ikevin127 I am stuck at this point #64793 (comment)

ikevin127 · 2025-06-26T22:37:48Z

Looking into it.

.github/workflows/pr-coverage-report.yml

github-actions · 2025-07-03T11:00:46Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

DylanDylann force-pushed the coverage-update-gh-action branch from 8e7fe97 to e20eaa7 Compare June 24, 2025 11:13

DylanDylann marked this pull request as ready for review June 24, 2025 11:16

DylanDylann requested a review from a team as a code owner June 24, 2025 11:16

melvin-bot bot requested review from ikevin127 and removed request for a team June 24, 2025 11:16

DylanDylann marked this pull request as draft June 24, 2025 15:32

DylanDylann closed this Jun 25, 2025

DylanDylann reopened this Jun 25, 2025

DylanDylann marked this pull request as ready for review June 25, 2025 09:59

DylanDylann marked this pull request as draft June 25, 2025 10:02

DylanDylann commented Jun 26, 2025

View reviewed changes

ikevin127 mentioned this pull request Jun 26, 2025

Create a GitHub Action to Update PR descriptions with code coverage metrics #64206

Open

6 tasks

ikevin127 reviewed Jun 27, 2025

View reviewed changes

.github/workflows/pr-coverage-report.yml Outdated Show resolved Hide resolved

ikevin127 reviewed Jun 27, 2025

View reviewed changes

.github/workflows/pr-coverage-report.yml Outdated Show resolved Hide resolved

add test coverage report workflow

4274c82

DylanDylann force-pushed the coverage-update-gh-action branch from bf97d16 to 4274c82 Compare July 1, 2025 09:52

DylanDylann marked this pull request as ready for review July 1, 2025 09:52

DylanDylann added 2 commits July 1, 2025 16:55

upgrade node version

6674170

update node version

b0dd49a

DylanDylann marked this pull request as draft July 1, 2025 14:47

DylanDylann added 4 commits July 2, 2025 17:12

split test

345e32e

test

9883a1d

update

a7dbc79

add istanbul

84b594e

DylanDylann added 3 commits July 3, 2025 19:29

update

cbaf222

add more shard

e40e886

try

0e88b11

DylanDylann closed this Jul 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

init #64793

init #64793

Uh oh!

DylanDylann commented Jun 24, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jun 24, 2025

Uh oh!

DylanDylann commented Jun 24, 2025

Uh oh!

DylanDylann Jun 26, 2025

Uh oh!

DylanDylann Jun 26, 2025

Uh oh!

DylanDylann commented Jun 26, 2025

Uh oh!

ikevin127 commented Jun 26, 2025

Uh oh!

DylanDylann commented Jun 26, 2025

Uh oh!

ikevin127 commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Uh oh!

init #64793

init #64793

Uh oh!

Conversation

DylanDylann commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 24, 2025

Uh oh!

DylanDylann commented Jun 24, 2025

Uh oh!

DylanDylann Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jun 26, 2025

Uh oh!

ikevin127 commented Jun 26, 2025

Uh oh!

DylanDylann commented Jun 26, 2025

Uh oh!

ikevin127 commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Uh oh!

DylanDylann commented Jun 24, 2025 •

edited

Loading