Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

ci: signed commits #95

Open
sparten11740 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ci: signed commits #95

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cf9fe5
ci: signed commits
sparten11740 Apr 25, 2024
c6cccad
ci: use release environment
sparten11740 Apr 25, 2024
de4dc93
chore: bump release action
sparten11740 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ on:
jobs:
version:
runs-on: ubuntu-latest
environment: release
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -37,11 +38,21 @@ jobs:
run: yarn install --immutable
- name: Prepare
run: yarn prepare
- name: Import GPG key
id: import-gpg
uses: crazy-max/ghaction-import-gpg@1a317071222a9bfb1839df1b58b1f0dcd893b589
Copy link
Collaborator

@mvayngrib mvayngrib Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@633kh4ck could u have a look at this?

Copy link
Contributor Author

@sparten11740 sparten11740 Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a review and I can't see any malicious attempts at trying to steal the keys. Note that I didn't review the openpgp package which has access to the private key here: https://github.com/crazy-max/ghaction-import-gpg/blob/60f6f3e9a98263cc2c51ebe1f9babe82ded3f0ba/src/openpgp.ts#L18-L20

Copy link
Contributor Author

@sparten11740 sparten11740 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge for now? the consequence of that GPG key leaking wouldn't be dramatic imo

Copy link
Collaborator

@mvayngrib mvayngrib May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @633kh4ck

Copy link
Contributor

@ChALkeR ChALkeR Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need a thirdparty action for this / why can't this be a command?

with:
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
passphrase: ${{ secrets.GPG_PASSPHRASE }}
git_config_global: true
git_user_signingkey: true
git_commit_gpgsign: true
- name: Version
uses: ExodusMovement/lerna-release-action/version@931392d04a637dccb561398add594a6cf61255b8
uses: ExodusMovement/lerna-release-action/version@c4c4b9d747ed0ef2750fa87b86eec3374c1b0e06
with:
github-token: ${{ secrets.GH_AUTOMATION_PAT }}
packages: ${{ inputs.packages }}
assignee: ${{ inputs.assignee }}
committer: exodus-github-hydra-bot
version-strategy: ${{ inputs.version-strategy }}
auto-merge: true