generated from Exabyte-io/template-definitions
-
Notifications
You must be signed in to change notification settings - Fork 0
Chore/SOF-6991 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azech-hqs
wants to merge
6
commits into
main
Choose a base branch
from
chore/SOF-6991
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/SOF-6991 #80
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f4590f1
update: place default entity in first position
azech-hqs 9df4b77
test: filter entity with default
azech-hqs 3cb3bba
chore: remove unused imports
azech-hqs b94c987
chore: derive path object from esse
azech-hqs 1d4f2e1
fix: swap default in array
azech-hqs 9e19f76
style: fix linter errors
azech-hqs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
import uniqBy from "lodash/uniqBy"; | ||
|
||
// Entity or object with path property | ||
interface PathObject { | ||
path: string; | ||
} | ||
import { PathSchema } from "../types"; | ||
|
||
type PathObject = Required<PathSchema>; | ||
|
||
// Filter conditions | ||
export interface FilterObject { | ||
path?: string; | ||
regex?: RegExp; | ||
isDefault?: boolean; | ||
} | ||
|
||
/** | ||
|
@@ -42,6 +42,24 @@ function isMultiPathSupported( | |
return expandedPaths.every((expandedPath) => isPathSupported(expandedPath, filterObjects)); | ||
} | ||
|
||
function setDefaultAsFirst( | ||
pathObjects: PathObject[], | ||
filterObjects: FilterObject[], | ||
): PathObject[] { | ||
const defaultFilter = filterObjects.find((f) => f.isDefault); | ||
if (!defaultFilter) return pathObjects; | ||
|
||
const defaultIndex = pathObjects.findIndex((pathObj) => { | ||
return isPathSupported(pathObj, [defaultFilter]); | ||
}); | ||
if (defaultIndex < 0 || pathObjects.length < 2) return pathObjects; | ||
|
||
const tmp = pathObjects[1]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above for the indices There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. corrected the error and added explanatory comment |
||
pathObjects[0] = pathObjects[defaultIndex]; | ||
pathObjects[1] = tmp; | ||
return pathObjects; | ||
} | ||
|
||
interface FilterEntityListProps { | ||
entitiesOrPaths: PathObject[]; // Array of objects defining entity path | ||
filterObjects?: FilterObject[]; // Array of path or regular expression objects | ||
|
@@ -50,13 +68,13 @@ interface FilterEntityListProps { | |
|
||
/** | ||
* Filter list of entity paths or entities by paths and regular expressions. | ||
* @return {Object[]} - filtered entity path objects or entities | ||
* @return - filtered entity path objects or entities | ||
*/ | ||
export function filterEntityList({ | ||
entitiesOrPaths, | ||
filterObjects = [], | ||
multiPathSeparator = "", | ||
}: FilterEntityListProps) { | ||
}: FilterEntityListProps): PathObject[] { | ||
if (!filterObjects || !filterObjects.length) return []; | ||
const filterObjects_ = filterObjects.map((o) => (o.regex ? { regex: new RegExp(o.regex) } : o)); | ||
|
||
|
@@ -69,5 +87,7 @@ export function filterEntityList({ | |
filtered = entitiesOrPaths.filter((e) => isPathSupported(e, filterObjects_)); | ||
} | ||
|
||
filtered = setDefaultAsFirst(filtered, filterObjects_); | ||
|
||
return uniqBy(filtered, "path"); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the magic number 2? Let's explain the logic