SOF-7599 update: use new made for slab generation #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -42,12 +42,12 @@ | |||
| "cell_type": "code", | |||
There was a problem hiding this comment.
| @@ -42,12 +42,12 @@ | |||
| "cell_type": "code", | |||
There was a problem hiding this comment.
Line #2. print("Available terminations:", [str(t) for t in terminations])
The numbering needs to be fixed, the logic should be:
2. Find possible terminations and select one
- Create CrystalPlanes
- Get all unique slabs and their corresponding terminations
- Visualize all slabs
- Select termination (or use the first one, with index zero by default)
3. Create a slab for the selected termination
Reply via ReviewNB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.