Fix possible fix(deps): 15 vulnerable dependencies in requirements.txt - #199
Open
begininvoke wants to merge 1 commit into
Open
Fix possible fix(deps): 15 vulnerable dependencies in requirements.txt#199begininvoke wants to merge 1 commit into
begininvoke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to
requirements.txt— a scan flagged the code below and it looked genuine. It is around line 11.The NLTK downloader extracts ZIP archives using zipfile.extractall() without sanitising the archive entries. An attacker can supply a malicious ZIP that contains path‑traversal filenames (e.g., '../../evil.py') or executable Python modules. When NLTK extracts such a package, the malicious code is written to arbitrary locations and may be imported automatically, leading to remote code execution and full system compromise. This is a classic Zip Slip vulnerability and, given the downloader runs with the privileges of the consuming application, it is rated CRITICAL. The immediate mitigation is to upgrade NLTK to version 3.9.3, which includes a fix, and to modify the _unzip_iter implementation to validate each entry before extraction.
Updated vulnerable dependencies (nltk, protobuf, sentencepiece, hydra-core) to versions that fix the reported CVEs.
For reference: rule
CVE-2025-14009. Rated critical.Take or leave whichever parts are useful. If this is not the right approach, closing is fine.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.