Multiplemutants - #313
Open
brendanwallace wants to merge 4 commits into
Open
Conversation
gofraser
reviewed
Oct 24, 2020
| */ | ||
| public static void deactivateMutation(Mutation mutation) { | ||
| activeMutation = -1; | ||
| activeMutations.clear(); |
Member
There was a problem hiding this comment.
This is fine, just wondering whether you intended to do activeMutations.remove(mutation.getId()) or something like that rather than deactivating all mutants? Otherwise we should maybe drop the parameter and rename the method to deactivateMutations() ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retool mutant instrumentation to allow for multiple active mutants
Allows multiple mutants to be active at once by:
This caused three tests to fail from expecting the wrong number of branch conditions and I'm not sure why (including changes to fix these tests, but would like some input on why they're failing and what other tests to add). Also aware that the commits haven't been squashed yet, etc.