Conversation
|
Review changes with Changed Files
|
|
Note: I will clean up the commit history before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 47.88% 47.88%
=======================================
Files 27 27
Lines 1988 1988
Branches 225 225
=======================================
Hits 952 952
Misses 1000 1000
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roedoejet
left a comment
roedoejet
left a comment
There was a problem hiding this comment.
I actually find
self.assertTrue((output_dir / "one--S1--L1--ckpt=77--v_ckpt=10--pred.wav").exists())
more readable than since assertTrue let's me know I'm not scanning for an equal sign or something, and for long statements like this that contain = it feels more readable to use the unittest syntax. That said, I don't really mind and am happy to approve.
assert (output_dir / "one--S1--L1--ckpt=77--v_ckpt=10--pred.wav").exists()
Squash of: - refactor(tests): replace all one-line self.assertTrue(x) by assert x - refactor(tests): replace all one-liner self.assertIn(a,b) by assert a in b - refactor(tests): replace assertEqual by assert == with a safe regex - refactor(tests): replace all remaining self.assert* by assert
- all pure pytest assertions - remove TestCase - use fixtures
joanise
force-pushed
the
dev.ej/pytest-assertions
branch
from
2606a33 to
0a95bb8
Compare
|
About readability, I agree some pytest-style asserts are less legible, like the regex one and possibly this example, but in order to remove |
2 participants
PR Goal?
100% conversion to pytest. We no longer use
TestCaseat all, it's all pytest-style cases and fixtures.How to test?
Compare running
pytestin this branch and the parent branch.Confidence?
high
Related PRs?
EveryVoiceTTS/EveryVoice#794