Skip to content

Replace pre-commit by prek#798

Open
joanise wants to merge 2 commits intodev.ej/update-install-instructionsfrom
dev.ej/prek
Open

Replace pre-commit by prek#798
joanise wants to merge 2 commits intodev.ej/update-install-instructionsfrom
dev.ej/prek

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented May 6, 2026

PR Goal?

Replace pre-commit by prek https://prek.j178.dev/

  • prek uses uv to install hooks much faster
  • built in Rust, with the explicit intent to be fast
  • it can run the hooks in parallel when multiple files are affected
  • it's a drop-in replacement requiring no other change than doing prek install instead of pre-commit install

Fixes?

my growing annoyance with pre-commit, and really, just cause all these new rust-based tools actually are nicer. :)

I've actually been using prek for months now, but I didn't to impose it on anyone. When I mentioned it to Samuel, he chided me for now sharing the joy, so this PR is me finally doing that sharing.

It's not a huge difference, but it's still enough difference I found it worth switching, especially given how trivial it is to switch.

Feedback sought?

Confirmation that you're happy with this change

Priority?

normal

Tests added?

n/a

How to test?

Install prek:

  • redo pip install -e ".[dev]", or just do pip install prek`

Remove the pre-commit hook if you installed it before

find .git -name pre-commit | xargs rm

(Re-)install the hook:

prek install
git submodule foreach "prek install"

Now commit some changes. prek will have to install everything in .pre-commit-config.yaml fresh, so the first time will be slow, though not nearly as slow as when using pre-commit, and subsequent times will be nice and fast.

Confidence?

high

Version change?

no

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#141
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#62

@joanise joanise requested review from SamuelLarkin and roedoejet May 6, 2026 16:18
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented May 6, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  Contributing.md Unsupported file format
  README.md Unsupported file format
  docs/install.md Unsupported file format
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  everyvoice/model/vocoder/HiFiGAN_iSTFT_lightning  0% smaller
  make-everyvoice-env Unsupported file format
  pyproject.toml Unsupported file format

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLI load time: 0:00.29
Pull Request HEAD: b464ef6c53e9d9293d4b70d7168ae47f6e45523a

Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1570 |     173387 | everyvoice.cli

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (3e02a69) to head (b464ef6).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           dev.ej/update-install-instructions     #798   +/-   ##
===================================================================
  Coverage                               83.41%   83.41%           
===================================================================
  Files                                      47       47           
  Lines                                    4203     4203           
  Branches                                  615      615           
===================================================================
  Hits                                     3506     3506           
  Misses                                    567      567           
  Partials                                  130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool - nice change! Thanks for sharing @joanise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants