Replace pre-commit by prek#798
Open
joanise wants to merge 2 commits intodev.ej/update-install-instructionsfrom
Open
Replace pre-commit by prek#798joanise wants to merge 2 commits intodev.ej/update-install-instructionsfrom
joanise wants to merge 2 commits intodev.ej/update-install-instructionsfrom
Conversation
Changed Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev.ej/update-install-instructions #798 +/- ##
===================================================================
Coverage 83.41% 83.41%
===================================================================
Files 47 47
Lines 4203 4203
Branches 615 615
===================================================================
Hits 3506 3506
Misses 567 567
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Replace pre-commit by prek https://prek.j178.dev/
prek installinstead ofpre-commit installFixes?
my growing annoyance with pre-commit, and really, just cause all these new rust-based tools actually are nicer. :)
I've actually been using prek for months now, but I didn't to impose it on anyone. When I mentioned it to Samuel, he chided me for now sharing the joy, so this PR is me finally doing that sharing.
It's not a huge difference, but it's still enough difference I found it worth switching, especially given how trivial it is to switch.
Feedback sought?
Confirmation that you're happy with this change
Priority?
normal
Tests added?
n/a
How to test?
Install
prek:pip install -e ".[dev]", or just dopip install prek`Remove the pre-commit hook if you installed it before
(Re-)install the hook:
Now commit some changes.
prekwill have to install everything in.pre-commit-config.yamlfresh, so the first time will be slow, though not nearly as slow as when usingpre-commit, and subsequent times will be nice and fast.Confidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/FastSpeech2_lightning#141
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#62