Skip to content

Make EveryVoice compatible with recent versions of click#787

Merged
joanise merged 4 commits intomainfrom
dev.ej/relax-click
Apr 20, 2026
Merged

Make EveryVoice compatible with recent versions of click#787
joanise merged 4 commits intomainfrom
dev.ej/relax-click

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Apr 15, 2026

PR Goal?

We've been carrying an unnecessary lock on click for a long time, which started with g2p and readalongs and we just carried it here automatically. Adapting to more recent versions is simple, so this PR does it.

Bumping pinned CI actions in this PR too because it's while examining this PR's CI logs I saw they're outdated.

Fixes?

click and fastapi being locked back in time

Feedback sought?

sanity checking

Priority?

normal

How to test?

tricky: to see that EV works with recent click, you need to manually install the dev.ej/relax-click branch in g2p and ReadAlongs/Studio before you attempt to install ev, because the published versions of those are still locking click<8.2.

So, use the branch dev.ej/force-recent-click instead of this PR's branch to install g2p and readalongs from github instead of pypi:

git checkout dev.ej/force-recent-click
pip install -e . --upgrade
pytest

Tests added?

covered by CI

Note, the relevant CI runs are those for branch dev.ej/force-recent-click, for the same reason noted above:

Confidence?

high

Version change?

nah

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#136
EveryVoiceTTS/wav2vec2aligner#28

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 15, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/matrix-tests.yml  13% smaller
  .github/workflows/test.yml  13% smaller
  everyvoice/model/aligner/wav2vec2aligner  0% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  everyvoice/tests/test_subsample.py  0% smaller
  pyproject.toml Unsupported file format

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

CLI load time: 0:00.26
Pull Request HEAD: 4538096b705040f0b26c4ddba6d9fe29b2852f5f
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1764 |     130134 | everyvoice.cli

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.97%. Comparing base (4c39155) to head (4538096).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files          47       47           
  Lines        4158     4158           
  Branches      611      611           
=======================================
  Hits         3450     3450           
  Misses        576      576           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise joanise force-pushed the dev.ej/relax-click branch 2 times, most recently from d890d5c to a850075 Compare April 16, 2026 15:52
Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @joanise

@joanise joanise force-pushed the dev.ej/relax-click branch from a850075 to 4538096 Compare April 20, 2026 19:05
@joanise joanise merged commit 0efb318 into main Apr 20, 2026
13 checks passed
@joanise joanise deleted the dev.ej/relax-click branch April 20, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants