Make EveryVoice compatible with recent versions of click#787
Merged
Conversation
Changed Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 47 47
Lines 4158 4158
Branches 611 611
=======================================
Hits 3450 3450
Misses 576 576
Partials 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d890d5c to
a850075
Compare
roedoejet
approved these changes
Apr 20, 2026
a850075 to
4538096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
We've been carrying an unnecessary lock on click for a long time, which started with g2p and readalongs and we just carried it here automatically. Adapting to more recent versions is simple, so this PR does it.
Bumping pinned CI actions in this PR too because it's while examining this PR's CI logs I saw they're outdated.
Fixes?
click and fastapi being locked back in time
Feedback sought?
sanity checking
Priority?
normal
How to test?
tricky: to see that EV works with recent click, you need to manually install the
dev.ej/relax-clickbranch in g2p and ReadAlongs/Studio before you attempt to install ev, because the published versions of those are still lockingclick<8.2.So, use the branch
dev.ej/force-recent-clickinstead of this PR's branch to install g2p and readalongs from github instead of pypi:Tests added?
covered by CI
Note, the relevant CI runs are those for branch
dev.ej/force-recent-click, for the same reason noted above:https://github.com/EveryVoiceTTS/EveryVoice/actions/runs/24471768155https://github.com/EveryVoiceTTS/EveryVoice/actions/runs/24472092477Confidence?
high
Version change?
nah
Related PRs?
EveryVoiceTTS/FastSpeech2_lightning#136
EveryVoiceTTS/wav2vec2aligner#28