Add option to skip checking GameChecksum #1028
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microlith57
approved these changes
Nov 29, 2025
maddie480-bot
added
the
1: review needed
DashingCat
approved these changes
Dec 28, 2025
Contributor
DashingCat
left a comment
DashingCat
left a comment
There was a problem hiding this comment.
Tested and works as expected.
| public bool IsValidWith(AsmChecksums other) { | ||
| if (other == null) return false; | ||
| if (GameChecksum != other.GameChecksum) return false; | ||
| if (GameChecksum != other.GameChecksum && !Everest.Relinker.SkipGameChecksum) return false; |
Contributor
There was a problem hiding this comment.
Maybe split the condition like this, so the current check remains identical after the change?
Suggested change
| if (GameChecksum != other.GameChecksum && !Everest.Relinker.SkipGameChecksum) return false; | |
| if (!Everest.Relinker.SkipGameChecksum) | |
| if (GameChecksum != other.GameChecksum) return false; |
JaThePlayer
approved these changes
Jan 15, 2026
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely useful to save time when testing Everest changes that do not alter the relinking process while having lots of mods enabled.