Conversation
…odel - Refactor `loadBookData` to be a suspend function that returns a success boolean. - Update `EditorView` to handle missing pages by triggering a notebook fix and navigating to the library. - Implement centralized error logging and snackbar notifications via `SnackState.logAndShowError`. - Add debug logging to `CanvasObserverRegistry` and `QuickNavViewModel` for canvas restoration and scrubbing. - Simplify `EditorView` logic by using a single entry point for book data loading based on `pageId`.
…- still not perfect, but better. --AI-- - Implement `DisposableEffect` in `EditorView` to properly register and unregister `EditorControlTower` observers. - Add lifecycle-aware observer management in `EditorControlTower` to prevent redundant job creation and ensure cleanup. - Refactor page transition logic in `EditorViewModel` and `EditorControlTower` to use `_toolbarState` updates instead of direct database calls. - Prevent duplicate page change emissions in `QuickNavViewModel` by tracking the last target page ID during scrubber gestures. - Add debug logging for page loading in `PageView` and navigation events in `NotableNavHost`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.