Added paginate function to help users paginate through database results.#153
Closed
davidw wants to merge 4 commits intoErlyORM:masterfrom
davidw:master
Closed
Added paginate function to help users paginate through database results.#153davidw wants to merge 4 commits intoErlyORM:masterfrom davidw:master
davidw wants to merge 4 commits intoErlyORM:masterfrom
davidw:master
Conversation
Contributor
|
Can you add some testing to this, I would really like to have some formal testing with proper on this |
Contributor
Author
|
Probably. Can you suggest some code to use as an example? I'm not very familiar with PropEr, nor CB testing, as it was mostly absent in the past. Definitely needed though, so I can take shot at it. |
Contributor
|
Sure, there are some good examples in "boss_news_controller_test.erl" if you need help feel free to contact me and we can maybe pair on this, I like the idea, but I really want to start having solid testing. |
This is so that foreign keys like, say, student_id can be ::uuid() and not ::string(), to better reflect the underlying database.
Contributor
Author
|
Ok, github has added some later commits to the pull request. I'm not sure how to make it remove those. |
Contributor
Author
|
Reopened as: #161 due to getting stuck in git hell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.