fix: align SDK metadata field names with Android and JS SDKs#94
Merged
leoromanovsky merged 1 commit intomainfrom Feb 5, 2026
Merged
fix: align SDK metadata field names with Android and JS SDKs#94leoromanovsky merged 1 commit intomainfrom
leoromanovsky merged 1 commit intomainfrom
Conversation
Rename metadata keys from sdkName/sdkVersion to sdkLanguage/sdkLibVersion to maintain consistency across all Eppo SDKs.
sameerank
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Would be nice to also match up the internal variable names across the code
eppo-ios-sdk/Sources/eppo/Constants.swift
Lines 2 to 3 in 0e4f22b
But this is the minimal change that is sufficient for now!
Member
Author
claude wanted to do that too but i reigned it in for minimal diff 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
iOS SDK was using different metadata field names (
sdkName,sdkVersion) compared to Android and JS SDKs (sdkLanguage,sdkLibVersion). This inconsistency can cause issues with downstream data processing.Changes
sdkName→sdkLanguageinEppoClient.swiftsdkVersion→sdkLibVersioninEppoClient.swiftEppoPrecomputedClient.swiftDecisions
sdkName,sdkVersionconstants)EppoPrecomputedClient.java:529-530) and JS SDK (eppo-client.ts:1342-1343)