Skip to content

fix: align SDK metadata field names with Android and JS SDKs#94

Merged
leoromanovsky merged 1 commit intomainfrom
fix/align-sdk-field-names
Feb 5, 2026
Merged

fix: align SDK metadata field names with Android and JS SDKs#94
leoromanovsky merged 1 commit intomainfrom
fix/align-sdk-field-names

Conversation

@leoromanovsky
Copy link
Copy Markdown
Member

Motivation

iOS SDK was using different metadata field names (sdkName, sdkVersion) compared to Android and JS SDKs (sdkLanguage, sdkLibVersion). This inconsistency can cause issues with downstream data processing.

Changes

  • Renamed metadata key sdkNamesdkLanguage in EppoClient.swift
  • Renamed metadata key sdkVersionsdkLibVersion in EppoClient.swift
  • Applied same changes to EppoPrecomputedClient.swift

Decisions

  • Only changed the metadata dictionary keys that are sent over the wire
  • Internal variable names remain unchanged (sdkName, sdkVersion constants)
  • Aligned with Android SDK (EppoPrecomputedClient.java:529-530) and JS SDK (eppo-client.ts:1342-1343)

Rename metadata keys from sdkName/sdkVersion to sdkLanguage/sdkLibVersion
to maintain consistency across all Eppo SDKs.
@leoromanovsky leoromanovsky marked this pull request as ready for review February 4, 2026 16:00
Copy link
Copy Markdown
Contributor

@sameerank sameerank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to also match up the internal variable names across the code

public let sdkName = "ios"
public let sdkVersion = "5.3.1"

But this is the minimal change that is sufficient for now!

@leoromanovsky leoromanovsky merged commit 63fa8aa into main Feb 5, 2026
2 checks passed
@leoromanovsky leoromanovsky deleted the fix/align-sdk-field-names branch February 5, 2026 02:51
@leoromanovsky
Copy link
Copy Markdown
Member Author

Would be nice to also match up the internal variable names across the code

public let sdkName = "ios"
public let sdkVersion = "5.3.1"

But this is the minimal change that is sufficient for now!

claude wanted to do that too but i reigned it in for minimal diff 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants