Conversation
yuraiz
commented
Aug 25, 2026
| regval_off = operand_s64s[1]; | ||
| // NOTE(yuraiz): Changed from operand_s64s[1] to fix sp on arm64. | ||
| // I don't know if it was valid for x64 before. | ||
| regval_off = operand_s64s[0]; |
Author
There was a problem hiding this comment.
That fixes conversion of encodings like
DW_AT_location (DW_OP_breg31 WSP+32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That PR defines base arm64 registers with dwarf and rdi register codes. I don't add arm64 build support nor include the ARM64_H in raddbg_main.c.
I verified that the definitions make sense by running radbin --dump on dwarf and rdi files and viewing variables in a running debugger.