Allow for mistmatch between native target and params for IPU #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17489259564/artifacts/3935606104. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
- Coverage 74.92% 74.92% -0.01%
==========================================
Files 56 56
Lines 17437 17438 +1
==========================================
Hits 13065 13065
- Misses 4372 4373 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giordano
commented
Sep 5, 2025
| @assert primal_params isa PrimalCompilerParams | ||
| if !(primal_params isa PrimalCompilerParams) | ||
| # XXX: This means mode is not propagated and rules are not applied for GPU code. | ||
| @safe_debug "NativeCompilerTarget without primal compiler params" primal_job |
There was a problem hiding this comment.
@vchuravy primal_job is not defined in this scope, should it be
Suggested change
| @safe_debug "NativeCompilerTarget without primal compiler params" primal_job | |
| @safe_debug "NativeCompilerTarget without primal compiler params" primal_params |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix JuliaIPU/IPUToolkit.jl#73 (comment)