[EAN-Issue-2531] Updated supra-extensions and bindings to support evm-automation flow in supra-chain#18
[EAN-Issue-2531] Updated supra-extensions and bindings to support evm-automation flow in supra-chain#18aregng wants to merge 4 commits intotask/issue-2528from
Conversation
…-automation flow in supra-chain - Added helper solidity scripts to prerform governance actions for localnet
| #[derive(Clone, Debug, Getters)] | ||
| pub struct AutomatedTransactionBuilder { | ||
| block_height: Option<u64>, | ||
| chain_id: Option<ChainId>, |
There was a problem hiding this comment.
Is there any reason why gas_price_cap is not an Option<u128> in the builder but other fields are? @aregng
There was a problem hiding this comment.
Initial reasoning having it non-optional does not make sense, so I have made it optional as well.
| self | ||
| } | ||
| pub fn gas_price_cap(mut self, gas_price_cap: u128) -> Self { | ||
| pub fn with_gas_price_cap(mut self, gas_price_cap: u128) -> Self { |
There was a problem hiding this comment.
is there a reason why gas_price_cap is not an Option<u128>?
| # | ||
| # - run this script | ||
| # | ||
| password="Blue!Tiger99@Moon.PROFILE" |
There was a problem hiding this comment.
@aregng, is this intentional? If this script will eventually be used for others then perhaps use a different mechanism , say .env, rather than keeping pwd here.
There was a problem hiding this comment.
This script is/was a quick solution for the local tests, for the testnet and mainnet more comprehensive set of tools or a tool will be created referencing the current bash and solidity scripts and the preference would be to have them as part of the foundation-multisig repo where all governance/foundation related actions are developed and reside rather than here.
But in any case I have updated this script as well not to have password hardcoded.
2 participants
Relates to: https://github.com/Entropy-Foundation/smr-moonshot/issues/2531