-
Notifications
You must be signed in to change notification settings - Fork 133
Zip with next #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zip with next #217
Changes from all commits
91fb707
ab77c89
8c39bf4
e27aa1f
dfb2fa6
739762f
c5c2a08
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ all = ["pandas"] | |
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| black = "^23.1" | ||
| parametrize = "^0.1.1" | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like pytest has this natively https://docs.pytest.org/en/stable/how-to/parametrize.html, so I'd prefer using that and it doesnt look like
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The issue is that pytest parametrize does not work with
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not that I know, I just didn't realize it didn't work. |
||
| pytest = "^7.3.1" | ||
| pylint = "^3.3.3" | ||
| pytest-cov = "^4.0.0" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using https://docs.pytest.org/en/stable/how-to/parametrize.html would avoid adding another library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It would also seemingly mean I would have to move the test out of the class or change it somehow to fit pytest parameterize, which would be more work, possibly refactoring the tests in that file.
I was hoping to avoid this by adding the library; it wasn't something I wanted to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I didn't realize until reading about the library that you couldn't use pytest natively with classes.