Upgrade Pylint to support Python 3.12 and 3.13 #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror (W0012) caused by R0917
… compatible dependency versions
samer-hamood
force-pushed
the
upgrade_pylint_to_support_python_3.12_and_3.13
branch
from
edeb77b to
d16ed5f
Compare
EntilZha
reviewed
Jan 27, 2025
Owner
EntilZha
left a comment
EntilZha
left a comment
There was a problem hiding this comment.
Overall LGTM, I think its fine to drop 3.8 to simplify the logic. Will merge once that's done
samer-hamood
force-pushed
the
upgrade_pylint_to_support_python_3.12_and_3.13
branch
from
5a01a3b to
c93e4f4
Compare
Contributor
Author
|
I think |
EntilZha
approved these changes
Jan 28, 2025
Owner
|
I just bypassed the 3.8 check since its going away :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint could not consistently run on Python 3.12 and 3.13, throwing errors the previous versions weren't. This prevented testing in CI for the later Python versions.
Upgraded Pylint to 3.3.3, adjusting the GitHub Action 'build' workflow to support Python 3.12 and 3.13 and disabling lint errors not visible with the previous versions of Python. This version of Pylint requires the minimum Python version to be 3.9. It's worth noting that Python 3.8 has reached EOL (See versions).