Skip to content

Conversation

@matthewlyons
Copy link

Hello All,

This is my first ever PR so I hope I don’t screw it up too bad. I’ve added a function that fires before the get request called loadingStart and changed the callback function to be loadingEnd to match.

These events allow users to make changes to the DOM outside of the pagination div (ie: show and hide a loading spinner or a modal), or fire off other events like Google Analytics tracking.

I have also added a setting useDefault which is true by default but if set to false removes the function that edits the pagination link to show the loading text.

That’s it. Let me know if there’s anything you’d like me to improve on!

@cam
Copy link
Member

cam commented Apr 24, 2020

@matthewlyons This looks great! I’ll review fully ASAP. Nice one! Most of us don’t do anywhere near as well in our first PR. I definitely didn’t 😅

@cam cam self-requested a review April 24, 2020 13:47
@matthewlyons
Copy link
Author

Thanks Cam! Let me know if there's anything you'd like me to change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants