Skip to content

chore(submodule): bump panther_ivy to land BGP suberror sort fix + nested pointers - #121

Merged
ElNiak merged 2 commits into
productionfrom
chore/bump-panther-ivy-bgp-suberror-fix
Jul 28, 2026
Merged

chore(submodule): bump panther_ivy to land BGP suberror sort fix + nested pointers#121
ElNiak merged 2 commits into
productionfrom
chore/bump-panther-ivy-bgp-suberror-fix

Conversation

@ElNiak

@ElNiak ElNiak commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Bumps panther_ivy 588c8ff7bbbdd649.

Carries

Commit What
9d69cee7 fix(bgp): widen variant member through a parent-sorted temp before storing
bbbdd649 chore(submodules): bump ivy-lsp7587caf, panther-ivy-plugin9d9c098

Why

bgp_speaker_test_update_announce had stopped compiling with ivy.logic.SortError: Ite then and else terms must have same sort: __queued_suberror_nd, queued_suberror(V0). Bisected in-container to a1aa0fd9 (23 Jul), which added the first live call sites for the RFC 4271 §6.3 error subcodes and thereby activated a latent ill-sorted assignment that had been dead code. Full analysis in ElNiak/PANTHER-Ivy#20.

The nested pointer bumps record the 2026-07-27 reconciliation (451/484/171 commits landing on each nested repo's own main). Content no-op: both new tips have trees byte-identical to the SHAs they replace.

Verification

  • bgp_speaker_test_update_announce compiles; bgp_speaker_test_collision still compiles (shared-file regression check)
  • CoAP corpus diff vs 588c8ff7 empty — 37 files / 3,072 lines untouched, so the D_WP2 evidence base and its dossier SHA citation are unaffected
  • Earlier full-suite baseline on this tree: 2,119 unit tests passing from a clean clone

Merge order

Land ElNiak/PANTHER-Ivy#20 firstbbbdd649 currently lives on that PR branch.

Summary by Sourcery

Enhancements:

  • Align nested Ivy-related submodules to their latest reconciled main commits without changing effective content.

…sted pointers

panther_ivy 588c8ff7 -> bbbdd649, carrying:
  9d69cee7  fix(bgp): widen variant member through parent-sorted temp before storing
  bbbdd649  chore(submodules): bump ivy-lsp + panther-ivy-plugin to merged main tips

The BGP fix unblocks compilation of bgp_speaker_test_update_announce, which had failed
with ivy.logic.SortError since a1aa0fd9 added the first live call sites for the RFC 4271
6.3 error subcodes. The nested pointer bumps are a content no-op — both new main tips
have trees byte-identical to the SHAs they replace.

CoAP corpus verified unchanged (37 files / 3,072 lines), so the D_WP2 evidence base and
its dossier citation are unaffected.

Merge order: land ElNiak/PANTHER-Ivy#20 first, since bbbdd649 is on that PR branch.
@sourcery-ai

sourcery-ai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the panther_ivy submodule to a newer commit that includes a BGP error-subcode sort fix and synchronized nested submodules, with no content changes in this repo beyond the submodule reference bump.

File-Level Changes

Change Details Files
Update panther_ivy submodule pointer to pull in BGP suberror sort fix and nested submodule reconciliations.
  • Advance the panther_ivy submodule SHA from 588c8ff7 to bbbdd649 in the testers plugin tree.
  • Transitively pull in fix for BGP error-subcode assignment by widening variant member through a parent-sorted temporary before storing.
  • Sync nested ivy-lsp and panther-ivy-plugin submodules to their reconciled main tips, which are byte-identical to previous trees in this context.
panther/plugins/services/testers/panther_ivy

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

PR ElNiak/PANTHER-Ivy#20 merged, so production advanced from 588c8ff7 to the merge
commit 83f2e591. Record the tip rather than bbbdd649 (now merely an ancestor), so the
pointer is canonical instead of immediately stale.

Content is unchanged from bbbdd649 — 83f2e591 is the merge commit for the same two
commits (9d69cee7 BGP suberror sort fix, bbbdd649 nested pointer bumps).
@ElNiak
ElNiak merged commit 8eb73f4 into production Jul 28, 2026
9 of 12 checks passed
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant