fix: ensure upload job is always marked as latest release#98
Merged
Conversation
Set make_latest: true on the combined-package release and make_latest: false on the individual-themes release so the outcome is deterministic regardless of job completion order. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pfeerick
force-pushed
the
fix/latest-release-ordering
branch
from
dab6bdc to
1048c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make_latest: trueto theuploadjob's release step so the combined-package release is always marked as the GitHub "latest" releasemake_latest: falseto theupload-individualjob's release step to prevent it from ever claiming "latest"Why
Both jobs run in parallel after
packagecompletes. Without explicitmake_latestsettings, whichever job finishes last would overwrite the other as the "latest" release — a non-deterministic race condition. This fix makes the outcome deterministic regardless of job completion order.Reviewer notes
No logic changes — only two lines added to the workflow YAML.