Skip to content

fix(engine): make ragged transport padding objective-safe - #7

Open
EazyReal wants to merge 1 commit into
review/pr1563-upstream-mainfrom
vmax/ragged-transport-safety
Open

fix(engine): make ragged transport padding objective-safe#7
EazyReal wants to merge 1 commit into
review/pr1563-upstream-mainfrom
vmax/ragged-transport-safety

Conversation

@EazyReal

@EazyReal EazyReal commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Purpose

Fork-local review mirror for upstream areal-project/AReaL#1566 and the root of the incomplete-group review stack. Do not merge this PR; the upstream PR is the landing authority.

Summary

  • add model-valid transport-only microbatches for ragged distributed schedules
  • bypass arbitrary objective weight and loss callbacks for transport rows
  • remove transport rows from ordinary and tree-packed forward outputs
  • preserve semantic transport markers when packed padding is a no-op

Transport padding is backend scheduling state only. It contributes no loss, gradients, metrics, normalization members, or returned semantic rows.

Exact range

08ab30fc8e0cfee70cc2b246119cd9e0c07ae0ce..b0dbd4c423de3be706a3978fd9d1ced4678298e6

Verification

  • 86 focused transport/objective tests passed
  • full pre-commit passed
  • hosted pre-commit and Ubuntu, macOS, SGLang-extra, and vLLM-extra installation checks passed
  • independent exact-range transport, Megatron, and Archon review found no actionable issue

A real multi-GPU pipeline canary is not available on this host. CodeRabbit did not produce a review body for this mirror, so its green status is not counted as review evidence.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eba48a8c-9f86-4d81-b8be-dad2d777f443

📥 Commits

Reviewing files that changed from the base of the PR and between 08ab30f and b0dbd4c.

📒 Files selected for processing (9)
  • areal/engine/core/__init__.py
  • areal/engine/core/train_engine.py
  • areal/engine/fsdp_engine.py
  • areal/engine/megatron_engine.py
  • areal/experimental/engine/archon_engine.py
  • areal/models/tree_attn/tree.py
  • areal/utils/data.py
  • tests/test_tree_transport.py
  • tests/test_utils.py

Comment @coderabbitai help to get the list of available commands.

@EazyReal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@EazyReal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@EazyReal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant