Open
Conversation
hgs2007
requested review from
LelsersLasers,
Packersfan6,
ShayManor and
shb-png
for some reason we got rid of it during the merge conflict part idk man
ShayManor
reviewed
Nov 5, 2025
src/autonomous_kart/autonomous_kart/nodes/pathfinder/pathfinder.py
Outdated
Show resolved
Hide resolved
src/autonomous_kart/autonomous_kart/nodes/pathfinder/pathfinder.py
Outdated
Show resolved
Hide resolved
src/autonomous_kart/autonomous_kart/nodes/pathfinder/pathfinder_node.py
Outdated
Show resolved
Hide resolved
LelsersLasers
requested changes
Nov 5, 2025
src/autonomous_kart/autonomous_kart/nodes/pathfinder/pathfinder.py
Outdated
Show resolved
Hide resolved
src/autonomous_kart/autonomous_kart/nodes/pathfinder/pathfinder.py
Outdated
Show resolved
Hide resolved
| # calculate speed command as % of total | ||
| speed_command /= max_speed | ||
|
|
||
| logger.info(f"Theta1: {theta1:.1f}°, Theta2: {theta2:.1f}°") |
Contributor
There was a problem hiding this comment.
I think a question for @ShayManor :
Is logging in the hotloop slow?
Contributor
There was a problem hiding this comment.
Sorry for the delay, not sure if this is still relevant. This is fine because it's on info and when we run we set logger mode to warning. Looking into how logger works, this will make one function call, fail the check, and return. This is fine.
Contributor
There was a problem hiding this comment.
def info(self, msg, *args, **kwargs):
if self.isEnabledFor(INFO):
self._log(INFO, msg, args, **kwargs)
The if fails, so no log is made, and the string format is not evaluated.
|
|
||
| speed_command = current_speed | ||
|
|
||
| theta1 = -1 * opencv_output[0] |
Contributor
There was a problem hiding this comment.
I might be missing it, but does it handle the case when OpenCV node is unable to find a left or right angle?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implemented a path-finding algorithm to keep the kart on the track. btw this branch is for pathfinding even tho its called opencv_testing