Skip to content

Fix new Chrome cookie policy. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix new Chrome cookie policy. #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions js/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,22 @@ function formCookieData(form) {
$(".expiration", form).removeClass("error");
}
}

/*
* New Chrome restrictions do not allow SameSite=None without Secure being
* marked as true.
*/
if (sameSite === 'no_restriction' && !secure) {
$(".sameSite", form).addClass("error");
$(".sameSite", form).focus();
$(".error-message").html("'No Restriction' requires that Secure be checked.");
$(".error-message").show();
return undefined;
} else {
$(".sameSite", form).removeClass("error");
$(".error-message").hide();
}

newCookie.secure = secure;
newCookie.httpOnly = httpOnly;
newCookie.sameSite = sameSite;
Expand Down
3 changes: 2 additions & 1 deletion popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
<label class="formLabel" i18n="sameSite"></label>
<select class="sameSite input" type="text">
<option selected="selected" i18n="SameSite_None" value="no_restriction"></option>
<option i18n="SameSite_Lax" value="lax"></option>
<option i18n="SameSite_Lax" value="lax" selected></option>
<option i18n="SameSite_Strict" value="strict"></option>
</select>
</div>
Expand All @@ -249,6 +249,7 @@
<input id="httpOnly-checkbox-new" class="httpOnly checkbox" type="checkbox">
</div>
</div>
<div class="error-message error" style="display: none"></div>
</div>
</div>

Expand Down