updated noresm_to_cmip7_aerosol.yaml#75
Conversation
mvertens
changed the title
|
@maritsandstad - the pre-commit tests now pass. |
maritsandstad
left a comment
maritsandstad
left a comment
There was a problem hiding this comment.
Have a few minor comments, but happy for this to go in
| from data_request_api.query import data_request as dr | ||
| from data_request_api.content import dump_transformation as dt | ||
|
|
There was a problem hiding this comment.
I'm generally not a huge fan of mid-code imports, is there a reason why this import is moved all the way down here?
There was a problem hiding this comment.
See comment below - this is required for the pre-commit hooks to pass. It's a lazy import.
| ml = 1.0 - float(int(ncpus_env) - 1) / 128.0 | ||
| else: | ||
| ml = "auto" # Default memory limit if NCPUS is not set | ||
| from dask.distributed import LocalCluster |
There was a problem hiding this comment.
Same with this, is there a reason why the import has to happen down here?
There was a problem hiding this comment.
See comment below - you need a lazy import for the pre-commit hooks.
| ocn_fx_fields=ocn_fx_fields, | ||
| ) | ||
| futures = client.compute([fut]) | ||
| from dask.distributed import wait, as_completed |
There was a problem hiding this comment.
Yes - it needs to be a lazy import in order for the pre-commit tests to pass. Otherwise - the .github workflow tests fail.
2 participants
Uh oh!
There was an error while loading. Please reload this page.