Skip to content

Added null check for text in HeaderFooter #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2025
Merged

Added null check for text in HeaderFooter #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83360dd
Added null check for text in HeaderFooter
AdrianEPPlus Aug 19, 2025
ad8c14f
check if null or empty
AdrianEPPlus Aug 19, 2025
3ae2c4a
Added test for issue2088
AdrianEPPlus Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EPPlus/Style/HeaderFooterTextFormat/ExcelHeaderFooterTextCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ private string ParseToHeaderFooterFormat(ExcelHeaderFooterTextItem current, Exce
if (current.FontSize != prev.FontSize)
{
hfstring += "&" + current.FontSize;
if (char.IsDigit(current.Text[0]))
if (!string.IsNullOrEmpty(current.Text) && char.IsDigit(current.Text[0]))
{
hfstring += " ";
}
Expand All @@ -748,7 +748,7 @@ private string ParseToHeaderFooterFormat(ExcelHeaderFooterTextItem current, Exce
else if (current.FontSize != null && prev.FontSize == null)
{
hfstring += "&" + current.FontSize;
if (char.IsDigit(current.Text[0]))
if ( !string.IsNullOrEmpty(current.Text) && char.IsDigit(current.Text[0]))
{
hfstring += " ";
}
Expand Down
33 changes: 33 additions & 0 deletions src/EPPlusTest/Issues/LegacyTests/Issues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Date Author Change
using OfficeOpenXml.FormulaParsing.Logging;
using OfficeOpenXml.Sparkline;
using OfficeOpenXml.Style;
using OfficeOpenXml.Style.HeaderFooterTextFormat;
using OfficeOpenXml.Table;
using OfficeOpenXml.Table.PivotTable;
using OfficeOpenXml.Utils.CompundDocument;
Expand All @@ -58,6 +59,7 @@ Date Author Change
using System.Reflection;
using System.Text;
using System.Threading;
using static Microsoft.ApplicationInsights.MetricDimensionNames.TelemetryContext;

namespace EPPlusTest
{
Expand Down Expand Up @@ -6219,5 +6221,36 @@ public void SumIfsRangeCriteriaArray()
Assert.AreEqual(0d, ws.Cells["F6"].Value);
}
}

[TestMethod]
public void i2078()
{
using var p = new ExcelPackage();
var ws =p.Workbook.Worksheets.Add("Sheet 1");
//ws.HeaderFooter.OddHeader.LeftAlignedText = "&12&A";
ws.HeaderFooter.OddHeader.LeftAligned.Add(new()
{
FontSize = 12,
FormatCode = ExcelHeaderFooterFormattingCodes.SheetName,
Text = ""
});
p.SaveAs("c:\\epplustest\\testoutput\\HeaderFooterIssue2078.xlsx");
}

[TestMethod]
public void i2088()
{
using var p = new ExcelPackage();
var ws = p.Workbook.Worksheets.Add("Sheet 1");
var fh = ws.HeaderFooter.FirstHeader;
FileInfo pic = new FileInfo(Resources.GetImageFullFileName("epplusobject.png"));
var drawing = ws.HeaderFooter.FirstHeader.InsertPicture(pic, PictureAlignment.Left);
drawing.Height = 40;

ws.HeaderFooter.FirstHeader.CenteredText = "pageTitle";
ws.HeaderFooter.FirstFooter.LeftAlignedText = $"{ExcelHeaderFooter.CurrentDate} {ExcelHeaderFooter.CurrentTime}";
ws.HeaderFooter.FirstFooter.RightAlignedText = $"Printing: {"user.DisplayName"} - {ExcelHeaderFooter.PageNumber}/{ExcelHeaderFooter.NumberOfPages}";
p.SaveAs("c:\\epplustest\\testoutput\\HeaderFooterIssue2088.xlsx");
}
}
}