Fixed some issue with arich sim-reco.#298
Conversation
…low eff regions and dead channels. Utils fixe dto boost performance, fixed few reco codes and added an analyzer. Also first test to check everything is compatible with main
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
…nges in the code digitization and clustering
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
gavinsdavies
left a comment
gavinsdavies
left a comment
There was a problem hiding this comment.
a handful of comments i seek feedback before approval.
be careful to review what the AI writes
Comments fix
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
Lamber -> Lumber
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
|
Should have fixed all known lil typos and it seems to merge fine. I know ARICH will need some more work to align and therefore reco for ring and PID. Do we want to wait to merge everything once ready? |
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
if we merge now (my preference) are there any downstream issues? things still run, no? |
…g object (recobase and SR) with filler fixed
…/emphaticsoft into feature/arich_may26
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
…/emphaticsoft into feature/arich_may26
…/emphaticsoft into feature/arich_may26
|
❌ CI build for EMPHATIC Failed at phase build on slf7 for maxopt -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build phase logs |
|
✔️ CI build for EMPHATIC Succeeded on slf7 for maxopt -- details available through the CI dashboard |
3 participants
Digitization fixed multiplicy, low eff regions and dead channels.
Utils fixe dto boost performance, fixed few reco codes and added an analyzer.
Also first test to check everything is compatible with main