forked from HackYourFutureBelgium/Module-Onboarding
-
Notifications
You must be signed in to change notification settings - Fork 0
ITP-2025-1|Elena Vasileia|Week 2|Feature form controls #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EL1VAS
wants to merge
33
commits into
main
Choose a base branch
from
Feature-Form-Controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the :root design pallete
Added base elements
Changed the header and paragraph in html
Added three articles with headers and paragraphs about our three topics. Added links to them
Removed css styling as this is an html file (wrongly added before)
Added img on Git branch article
…Onboarding into feature/wireframe i
Added images in articles.
Brussels, Elena Vasileia, Week 1, Wireframe index.html alteration
Changed paper command to a light yellow color
Centered headers and paragraph included, also made them bigger
Center h2 and changed font size in all paragraphs
Tried to chenge the footer allignment but it didn't respond as expected
Added the name filed that needs to be at least 2 letters and it's mandatory.
Added email filed that is mandatory and has the email type.
Added a radio button to choose blue color. Made it required so client will have to mandatory choose one of three.
Added green and black color options without making them required as only one of three should marked as required to make the choice mandatory.
Added sizes option making them mandatory to choose one
Added my name :)
Hello! Since my branch of feature wireframe was already accepted and I kept saving changes for Form-Controls in that branch, I am now submitting a new branch for review.
Added submit button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Changed the index file of Form controls.
I asked for name, email to verify customer.
I added a choice of three t-shirt colors and 6 sizes to choose from (mandatory).
I added my name to the assignement
Questions
No questions at all! :)
Ask any questions you have for your reviewer.