Skip to content

Toward 12 factor apps #1 - #50

Open
jschaeff wants to merge 13 commits into
masterfrom
migrate-to-uv
Open

Toward 12 factor apps #1#50
jschaeff wants to merge 13 commits into
masterfrom
migrate-to-uv

Conversation

@jschaeff

@jschaeff jschaeff commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Changes in the wfcatalog collector :

Updates

Code improvement

Features

  • If the config.json file is not provided, the program tries to load from environment variables
  • Remove the "VERSION" from configuration file. Managed from the pyproject.toml
  • If no log file specified, prints to stdout

jschaeff added 2 commits June 8, 2026 17:17
With a working and up to date Dockerfile
@jschaeff jschaeff changed the title [Draft] Migrate to uv [Draft] toward 12 factor apps #1 Jun 9, 2026
@jschaeff jschaeff changed the title [Draft] toward 12 factor apps #1 Toward 12 factor apps #1 Jun 9, 2026
@jschaeff
jschaeff requested a review from jppzanetti June 9, 2026 09:45
Comment thread collector/src/WFCatalogCollector.py Outdated
Comment thread collector/README.md
Comment thread collector/README.md Outdated
Comment thread collector/README.md
Comment thread collector/README.md
1. load from WFCAT_CONF_DIR/config.json if exists
2. load from WFCAT_* environment variables

Improve documentation
@jschaeff

Copy link
Copy Markdown
Contributor Author

I also added more unit tests to load the configuration.

Thanks for the review @jppzanetti . Be as severe as possible so the code quality improves :)

@jppzanetti

Copy link
Copy Markdown
Contributor

Statically the code looks fine. I'm trying to integrate with our deployment, but there's one change that I'd like to take this opportunity to integrate here as well. (After all, having a single codebase for all deployments is the first of the twelve factors.)

Do you prefer if I push it direct to this branch, or should I make a PR into here?

In short, it is an extra (optional) config value MONGO.ENGINE that's either "mongodb" (default), or "docdb", for our AWS deployment.

@jschaeff

Copy link
Copy Markdown
Contributor Author

Cool, you can add it to this branch.

Thanks

@jppzanetti

Copy link
Copy Markdown
Contributor

Sorry, it took me much longer than I expected to make it run in our setup, but I think the changes I made internally will make it a lot easier to develop in the future.

@jppzanetti

Copy link
Copy Markdown
Contributor

If you agree with the commit above, I'll merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[collector] migrate to UV to improve reproductible installation process [collector] update obspy dependency

2 participants