Toward 12 factor apps #1 - #50
Conversation
With a working and up to date Dockerfile
Load config from environment variables
1. load from WFCAT_CONF_DIR/config.json if exists 2. load from WFCAT_* environment variables Improve documentation
|
I also added more unit tests to load the configuration. Thanks for the review @jppzanetti . Be as severe as possible so the code quality improves :) |
|
Statically the code looks fine. I'm trying to integrate with our deployment, but there's one change that I'd like to take this opportunity to integrate here as well. (After all, having a single codebase for all deployments is the first of the twelve factors.) Do you prefer if I push it direct to this branch, or should I make a PR into here? In short, it is an extra (optional) config value |
|
Cool, you can add it to this branch. Thanks |
|
Sorry, it took me much longer than I expected to make it run in our setup, but I think the changes I made internally will make it a lot easier to develop in the future. |
|
If you agree with the commit above, I'll merge this. |
Changes in the wfcatalog collector :
Updates
Code improvement
Features