Adds error check to IOStream for FileFreq options#457
Merged
philipwjones merged 1 commit intoJul 3, 2026
Conversation
When append mode is used, the FileFreq options must be supplied but an error check was missing to detect this case User documentation was also revised to note the requirement and some instructions for handling a special case.
Author
|
CTests pass on PM cpu and gpu. Also tested error case when FileFreq options missing to verify abort and error message are triggered. Built revised docs and viewed them successfully. |
xylar
approved these changes
Jul 2, 2026
There was a problem hiding this comment.
Reviewed by inspection and @philipwjones's testing. Thanks @philipwjones! This looks like exactly what we need --both the error message and the updated docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When append mode is used, the FileFreq options must be supplied but an error check was missing to detect this case. User documentation was also revised to note the requirement and add some instructions for handling a special case.
Fixes #407
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build